dm-writecache: add unlikely for returned value of rb_next/prev
PATCH 1/1 dm-writecache: add unlikely for returned value of rb_next/prev
From: Huaisheng Ye <[email protected]>
In functions writecache_discard and writecache_find_entry, there is high probablity that the pointer of structure rb_node doesn't equal to NULL. Add unlikly for the pointer node.
Signed-off-by Huaisheng Ye <[email protected]>
--- drivers/md/dm-writecache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/dm-writecache.c +2 -2
@@ -571,7 +571,7 @@ static struct wc_entry *writecache_find_entry(struct dm_writecache *wc, node =rb_prev (&e->rb_node); else node =rb_next (&e->rb_node); -if (!node) +if (unlikely (!node))return e; e2 = container_of(node, struct wc_entry, rb_node);if (read_original_sector (wc, e2) != block)
@@ -804,7 +804,7 @@ static void writecache_discard(struct dm_writecache *wc, sector_t start, sector_writecache_free_entry (wc, e); } -if (!node) +if (unlikely (!node))break ; e = container_of(node, struct wc_entry, rb_node);
Signature · 1 line
1.8.3.1
Quoted 7 lines · Huaisheng Ye
From: Huaisheng Ye <[email protected]>
In functions
writecache_discardandwritecache_find_entry, there is high probablity that the pointer of structurerb_nodedoesn't equal to NULL. Add unlikly for the pointer node.Signed-off-by Huaisheng Ye <[email protected]>
Acked-by Mikulas Patocka <[email protected]>
Quoted 29 lines
--- drivers/md/dm-writecache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/md/dm-writecache.c +2
-2@@ -571,7 +571,7 @@ static struct wc_entry *writecache_find_entry(struct dm_writecache *wc, node =rb_prev (&e->rb_node); else node =rb_next (&e->rb_node); -if (!node) +if (unlikely (!node))return e; e2 = container_of(node, struct wc_entry, rb_node);if (read_original_sector (wc, e2) != block)@@ -804,7 +804,7 @@ static void writecache_discard(struct dm_writecache *wc, sector_t start, sector_writecache_free_entry (wc, e); } -if (!node) +if (unlikely (!node))break ; e = container_of(node, struct wc_entry, rb_node);Signature · 1 line
1.8.3.1