net: atm: Fix potential Spectre v1 vulnerabilities
Subsystems (3)
PATCH 1/1 net: atm: Fix potential Spectre v1 vulnerabilities
arg is controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/atm/lec.c:715 lec_mcast_attach() warn: potential spectre issue 'dev_lec' [r] (local cap)
Fix this by sanitizing arg before using it to index dev_lec.
Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1].
[1] https://lore.kernel.org/lkml/[email protected]/
--- net/atm/lec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
net/atm/lec.c +5 -1
@@ -710,7 +710,10 @@ static int lec_vcc_attach(struct atm_vcc *vcc, void __user *arg)static int lec_mcast_attach (struct atm_vcc *vcc,int arg) { -if (arg <0 || arg >=MAX_LEC_ITF || !dev_lec[arg]) +if (arg <0 || arg >=MAX_LEC_ITF ) +return -EINVAL ; + arg =array_index_nospec (arg,MAX_LEC_ITF ); +if (!dev_lec[arg])return -EINVAL ; vcc->proto_data = dev_lec[arg];return lec_mcast_make (netdev_priv (dev_lec[arg]), vcc);
@@ -728,6 +731,7 @@ static int lecd_attach(struct atm_vcc *vcc, int arg) i = arg;if (arg >=MAX_LEC_ITF )return -EINVAL ; + i =array_index_nospec (arg,MAX_LEC_ITF );if (!dev_lec[i]) {int size;
Signature · 1 line
2.21.0
David Miller
maintainerFrom: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 15 Apr 2019 15:57:23 -0500
Quoted 9 lines
arg is controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/atm/lec.c:715lec_mcast_attach()warn: potential spectre issue 'dev_lec' [r] (local cap)Fix this by sanitizing arg before using it to index
dev_lec.
Quoted 7 lines
Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1].
[1] https://lore.kernel.org/lkml/[email protected]/
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied and queued up for -stable.
Quoted 16 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 15 Apr 2019 15:57:23 -0500Quoted 13 lines
arg is controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/atm/lec.c:715lec_mcast_attach()warn: potential spectre issue 'dev_lec' [r] (local cap)Fix this by sanitizing arg before using it to index
dev_lec.Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1].
Quoted 6 lines
Quoted 3 lines
[1] https://lore.kernel.org/lkml/[email protected]/
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied and queued up for -stable.
Thank you, Dave.
--
Gustavo