usb: typec: ucsi: ccg: add firmware flashing support

PATCH Superseded Greg Kroah-Hartman 1 participant 1 message Apr 16, 2019 USB

lore

Share & tools

lore

Greg Kroah-Hartman

author maintainer

2019-04-16 10:00 UTC #0 lore raw

PATCH v2 3/7 usb: typec: ucsi: ccg: add firmware flashing support

Review

Quoted 9 lines · Heikki Krogerus

(quoted diff) +9 -0

+static ssize_t do_flash_show(struct device *dev,
+			     struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "[Usage]\n"
+		"1) copy ccg_boot.cyacd /lib/firmware/\n"
+		"2) copy ccg_primary.cyacd /lib/firmware/\n"
+		"3) copy ccg_secondary.cyacd /lib/firmware/\n"
+		"4) echo 1 > do_flash\n");
+}

That is cute, but no, the kernel does NOT provide built-in help texts for sysfs files. If you know of any existing ones that do this, please point them out to me and I will go delete them from the tree.

sysfs is "one value per file", and a "multi-line-help-text" is not a single value.

That is what the Documentation/ABI files are for, which I do not see an update for in this patch so I can not take it, sorry :(

thanks,

greg k-h