PM / Domains: remove unnecessary unlikely()
Subsystems (4)
PATCH 1/1 PM / Domains: remove unnecessary unlikely()
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely.
Signed-off-by Yangtao Li <[email protected]>
--- drivers/base/power/domain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/base/power/domain.c +2 -4
@@ -391,11 +391,9 @@ int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state)if (unlikely (!genpd->set_performance_state))return -EINVAL ; -if (unlikely (!dev->power.subsys_data || - !dev->power.subsys_data->domain_data)) { -WARN_ON (1 ); +if (WARN_ON (!dev->power.subsys_data || + !dev->power.subsys_data->domain_data))return -EINVAL ; - }genpd_lock (genpd);
Signature · 1 line
2.17.0
Quoted 5 lines · Yangtao Li
WARN_ON()already contains anunlikely(), so it's not necessary to use unlikely.Signed-off-by Yangtao Li <[email protected]>
Reviewed-by Ulf Hansson <[email protected]>
Kind regards
Uffe
Quoted 25 lines
--- drivers/base/power/domain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/base/power/domain.c +2
-5@@ -391,11 +391,9 @@ int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state)if (unlikely (!genpd->set_performance_state))return -EINVAL ; -if (unlikely (!dev->power.subsys_data || - !dev->power.subsys_data->domain_data)) { -WARN_ON (1 ); +if (WARN_ON (!dev->power.subsys_data || + !dev->power.subsys_data->domain_data))return -EINVAL ; - }genpd_lock (genpd); --2.17.0
Quoted 32 lines · CEST Ulf Hansson
Quoted 5 lines · Yangtao Li
WARN_ON()already contains anunlikely(), so it's not necessary to use unlikely.Signed-off-by Yangtao Li <[email protected]>Reviewed-by Ulf Hansson <[email protected]>Kind regards
UffeQuoted 20 lines
--- drivers/base/power/domain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/base/power/domain.c +2
-4@@ -391,11 +391,9 @@ int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state)if (unlikely (!genpd->set_performance_state))return -EINVAL ; -if (unlikely (!dev->power.subsys_data || - !dev->power.subsys_data->domain_data)) { -WARN_ON (1 ); +if (WARN_ON (!dev->power.subsys_data || + !dev->power.subsys_data->domain_data))return -EINVAL ; - }
Quoted 6 lines
Quoted 5 lines
drivers/base/power/domain.c +0
-1genpd_lock (genpd); --2.17.0
Patch applied, thanks!