Skip to contentSkip to conversation

adwaita-icon-theme: do not delete symbolic svg but pack them in ${PN}-symbolic

PATCH In review Andreas Müller 3 participants 8 messages Apr 17, 2019 – May 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adwaita-icon-theme: do not delete symbolic svg but pack them in ${PN}-symbolic

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

---
 meta/recipes-gnome/gnome/adwaita-icon-theme_3.28.0.bb | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
meta/recipes-gnome/gnome/adwaita-icon-theme_3.28.0.bb +2 -8
index 40dd35ba30..6e453a0163 100644
@@ -18,13 +18,6 @@ SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz \
 SRC_URI[md5sum] = "b25b2d82cbebf2cc9cd469457b604f2c"
 SRC_URI[sha256sum] = "7aae8c1dffd6772fd1a21a3d365a0ea28b7c3988bdbbeafbf8742cda68242150"
 
-do_install_append() {
-	# Build uses gtk-encode-symbolic-svg to create png versions:
-        # no need to store the svgs anymore.
-	rm -f ${D}${prefix}/share/icons/Adwaita/scalable/*/*-symbolic.svg \
-	      ${D}${prefix}/share/icons/Adwaita/scalable/*/*-symbolic-rtl.svg
-}
-
 PACKAGES = "${PN}-cursors ${PN}-symbolic-hires ${PN}-symbolic ${PN}-hires ${PN}"
 
 RREPLACES_${PN} = "gnome-icon-theme"
@@ -37,7 +30,8 @@ FILES_${PN}-symbolic-hires = "${prefix}/share/icons/Adwaita/96x96/*/*.symbolic.p
                               ${prefix}/share/icons/Adwaita/48x48/*/*.symbolic.png \
                               ${prefix}/share/icons/Adwaita/32x32/*/*.symbolic.png"
 FILES_${PN}-symbolic = "${prefix}/share/icons/Adwaita/16x16/*/*.symbolic.png \
-                        ${prefix}/share/icons/Adwaita/24x24/*/*.symbolic.png"
+                        ${prefix}/share/icons/Adwaita/24x24/*/*.symbolic.png \
+                        ${prefix}/share/icons/Adwaita/scalable/*/*-symbolic*.svg"
 FILES_${PN}-hires = "${prefix}/share/icons/Adwaita/256x256/ \
                      ${prefix}/share/icons/Adwaita/512x512/"
 FILES_${PN} = "${prefix}/share/icons/Adwaita/ \
Signature · 1 line
2.20.1
#1 lore raw
Quoted 8 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

Quoted 7 lines

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

ping?

#2 lore raw
Quoted 10 lines · Andreas Müller
Quoted 8 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

Quoted 8 lines
Quoted 7 lines

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

ping?

Something wrong with this bugfix?

Andreas

#3 lore raw
Quoted 15 lines · Andreas Müller
Quoted 13 lines · Andreas Müller
Quoted 11 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

ping?

Something wrong with this bugfix?

pingediping

#4 lore raw
Quoted 17 lines · Andreas Müller
Quoted 15 lines · Andreas Müller
Quoted 13 lines · Andreas Müller
Quoted 11 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

ping?

Something wrong with this bugfix?

pingediping

Should write some auto-ping script..

PING

#5 lore raw
Quoted 16 lines · Andreas Müller
Quoted 15 lines · Andreas Müller
Quoted 14 lines · Andreas Müller
Quoted 13 lines · Andreas Müller
Quoted 12 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

ping?

Something wrong with this bugfix?

pingediping

Should write some auto-ping script..

Its been sitting in stable/thud-next.

https://git.openembedded.org/openembedded-core-contrib/commit/?h=stable/thud-next&id=9c63433010aae6891149a7605a637bee879dc4ef

Quoted 2 lines

PING

#6 lore raw
In reply to Andreas Müller
Quoted 16 lines · Andreas Müller
Quoted 15 lines · Andreas Müller
Quoted 14 lines · Andreas Müller
Quoted 13 lines · Andreas Müller
Quoted 12 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

(From OE-Core rev: 0911e7d2f5443210b594a198ada8465af7a2fc78)

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

ping?

Something wrong with this bugfix?

pingediping

Should write some auto-ping script..

correction.. its in thud proper. I didn't send a patch review nor pull request so I wasn't expecting it there.

https://git.openembedded.org/openembedded-core/commit/?h=thud&id=9c63433010aae6891149a7605a637bee879dc4ef

Quoted 2 lines

PING

#7 lore raw
Quoted 32 lines · On Tue, 2019-05-21 at 21:47 -0700, akuster808 wrote:
Quoted 30 lines · Andreas Müller
Quoted 28 lines · Andreas Müller
Quoted 26 lines · Andreas Müller
Quoted 15 lines · Andreas Müller
Quoted 13 lines · Andreas Müller

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with
XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2]
http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

Quoted 7 lines
Quoted 6 lines

(From OE-Core rev:
0911e7d2f5443210b594a198ada8465af7a2fc78)

Signed-off-by Richard Purdie <

[email protected]>

ping?

Something wrong with this bugfix?

Quoted 7 lines
Quoted 2 lines
Quoted 1 line

pingediping

Should write some auto-ping script..

correction.. its in thud proper. I didn't send a patch review nor pull request so I wasn't expecting it there.

https://git.openembedded.org/openembedded-core/commit/?h=thud&id=9c63433010aae6891149a7605a637bee879dc4ef

Sorry, somehow I was thinking I'd somehow missed a pull request and that needed merging :/

Cheers,

Richard