Skip to contentSkip to conversation

nfsd: CB_RECALL can race with FREE_STATEID

PATCH In review Scott Mayhew 3 participants 11 messages Apr 18, 2019 – May 2, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: CB_RECALL can race with FREE_STATEID

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the time it received the CB_RECALL.

---
 fs/nfsd/nfs4state.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/nfsd/nfs4state.c +8 -0
index 6a45fb00c5fc..e88e429133a8 100644
@@ -3958,6 +3958,14 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb,
 			rpc_delay(task, 2 * HZ);
 			return 0;
 		}
+		/*
+		 * Race: client may have done a FREE_STATEID before
+		 * receiving the CB_RECALL.
+		 */
+		if (dp->dl_stid.sc_type == NFS4_REVOKED_DELEG_STID &&
+				refcount_read(&dp->dl_stid.sc_count) == 1 &&
+				list_empty(&dp->dl_recall_lru))
+			return 1;
 		/*FALLTHRU*/
 	default:
 		return -1;
Signature · 1 line
2.17.2
#1 lore raw
Quoted 6 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the time it received the CB_RECALL.

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback channel is working (am I wrong?) and telling the client to set up a new one is probably not going to help. The best we can do is probably just give up and let the client deal with the ensuing RECALLABLE_STATE_REVOKED flag.

--b.

Quoted 27 lines
---
 fs/nfsd/nfs4state.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/nfsd/nfs4state.c +8 -0
index 6a45fb00c5fc..e88e429133a8 100644
@@ -3958,6 +3958,14 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb,
 			rpc_delay(task, 2 * HZ);
 			return 0;
 		}
+		/*
+		 * Race: client may have done a FREE_STATEID before
+		 * receiving the CB_RECALL.
+		 */
+		if (dp->dl_stid.sc_type == NFS4_REVOKED_DELEG_STID &&
+				refcount_read(&dp->dl_stid.sc_count) == 1 &&
+				list_empty(&dp->dl_recall_lru))
+			return 1;
 		/*FALLTHRU*/
 	default:
 		return -1;
Signature · 1 line
2.17.2
#2 lore raw
Quoted 8 lines · J. Bruce Fields
Quoted 6 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the time it received the CB_RECALL.

Quoted 6 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 3 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just give up

That's what the patch is essentially doing. Or are you saying don't even bother with the checks but still return 1 so we don't set the SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 2 lines

and let the client deal with the ensuing
RECALLABLE_STATE_REVOKED flag.

The client's already dealing with the RECALLABLE_STATE_REVOKED flag, that's why it sent a TEST_STATEID and FREE_STATEID before it got this particular CB_RECALL. The idea behind the patch is to not give the state manager on the client additional work by setting CB_PATH_DOWN when the callback channel is clearly working...

-Scott

Quoted 30 lines

--b.

Quoted 27 lines
---
 fs/nfsd/nfs4state.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/nfsd/nfs4state.c +8 -0
index 6a45fb00c5fc..e88e429133a8 100644
@@ -3958,6 +3958,14 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb,
 			rpc_delay(task, 2 * HZ);
 			return 0;
 		}
+		/*
+		 * Race: client may have done a FREE_STATEID before
+		 * receiving the CB_RECALL.
+		 */
+		if (dp->dl_stid.sc_type == NFS4_REVOKED_DELEG_STID &&
+				refcount_read(&dp->dl_stid.sc_count) == 1 &&
+				list_empty(&dp->dl_recall_lru))
+			return 1;
 		/*FALLTHRU*/
 	default:
 		return -1;
Signature · 1 line
2.17.2
#3 lore raw
Quoted 22 lines · Scott Mayhew
Quoted 8 lines · J. Bruce Fields
Quoted 6 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the time it received the CB_RECALL.

Quoted 6 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 7 lines
Quoted 3 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just give up

That's what the patch is essentially doing. Or are you saying don't even bother with the checks but still return 1 so we don't set the SEQ4_STATUS_CB_PATH_DOWN flag?

Right, I don't see any point returning -1 (which ends up setting CB_PATH_DOWN) in any case where we get an nfs-level error. If the client got so far as returning an error, then the callback path is working.

I'm not sure exactly what errors *should* result in CB_PATH_DOWN, though. ETIMEDOUT, ENOTCONN, EIO? And maybe we should be checking for those in nfsd4_cb_done, and do away with the convention that -1 means CB_PATH_DOWN. I don't think there's a reason individual callback ops would need different rules for when to mark the callback channel down.

--b.

Quoted 41 lines
Quoted 3 lines

and let the client deal with the ensuing
RECALLABLE_STATE_REVOKED flag.

The client's already dealing with the RECALLABLE_STATE_REVOKED flag, that's why it sent a TEST_STATEID and FREE_STATEID before it got this particular CB_RECALL. The idea behind the patch is to not give the state manager on the client additional work by setting CB_PATH_DOWN when the callback channel is clearly working...

-Scott

Quoted 30 lines

--b.

Quoted 27 lines
---
 fs/nfsd/nfs4state.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/nfsd/nfs4state.c +8 -0
index 6a45fb00c5fc..e88e429133a8 100644
@@ -3958,6 +3958,14 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb,
 			rpc_delay(task, 2 * HZ);
 			return 0;
 		}
+		/*
+		 * Race: client may have done a FREE_STATEID before
+		 * receiving the CB_RECALL.
+		 */
+		if (dp->dl_stid.sc_type == NFS4_REVOKED_DELEG_STID &&
+				refcount_read(&dp->dl_stid.sc_count) == 1 &&
+				list_empty(&dp->dl_recall_lru))
+			return 1;
 		/*FALLTHRU*/
 	default:
 		return -1;
Signature · 1 line
2.17.2
#4 lore raw
Quoted 31 lines · J. Bruce Fields
Quoted 22 lines · Scott Mayhew
Quoted 8 lines · J. Bruce Fields
Quoted 6 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the time it received the CB_RECALL.

Quoted 6 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 7 lines
Quoted 3 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just give up

That's what the patch is essentially doing. Or are you saying don't even bother with the checks but still return 1 so we don't set the SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 7 lines

Right, I don't see any point returning -1 (which ends up setting CB_PATH_DOWN) in any case where we get an nfs-level error. If the client got so far as returning an error, then the callback path is working.

I'm not sure exactly what errors *should* result in CB_PATH_DOWN, though. ETIMEDOUT, ENOTCONN, EIO?

I'm not sure either. Looking at call_status/call_timeout/rpc_check_timeout, it looks to me like ENOTCONN will be translated to ETIMEDOUT because nfsd4_run_cb_work sets the RPC_TASK_SOFTCONN flag in the call to rpc_call_async.

It looks like call_status can return EHOSTDOWN, ENETDOWN, EHOSTUNREACH, ENETUNREACH, and EPERM... should those be handled as well?

-Scott

Quoted 48 lines

And maybe we should be checking for
those in nfsd4_cb_done, and do away with the convention that -1 means CB_PATH_DOWN. I don't think there's a reason individual callback ops would need different rules for when to mark the callback channel down.

--b.

Quoted 41 lines
Quoted 3 lines

and let the client deal with the ensuing
RECALLABLE_STATE_REVOKED flag.

The client's already dealing with the RECALLABLE_STATE_REVOKED flag, that's why it sent a TEST_STATEID and FREE_STATEID before it got this particular CB_RECALL. The idea behind the patch is to not give the state manager on the client additional work by setting CB_PATH_DOWN when the callback channel is clearly working...

-Scott

Quoted 30 lines

--b.

Quoted 27 lines
---
 fs/nfsd/nfs4state.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/nfsd/nfs4state.c +8 -0
index 6a45fb00c5fc..e88e429133a8 100644
@@ -3958,6 +3958,14 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb,
 			rpc_delay(task, 2 * HZ);
 			return 0;
 		}
+		/*
+		 * Race: client may have done a FREE_STATEID before
+		 * receiving the CB_RECALL.
+		 */
+		if (dp->dl_stid.sc_type == NFS4_REVOKED_DELEG_STID &&
+				refcount_read(&dp->dl_stid.sc_count) == 1 &&
+				list_empty(&dp->dl_recall_lru))
+			return 1;
 		/*FALLTHRU*/
 	default:
 		return -1;
Signature · 1 line
2.17.2
#5 lore raw
Quoted 57 lines · Scott Mayhew
Quoted 41 lines · J. Bruce Fields
Quoted 34 lines · Scott Mayhew
Quoted 12 lines · J. Bruce Fields
Quoted 10 lines · Scott Mayhew

While trying to track down some issues involving large numbers of
delegations being recalled/revoked, I caught the server setting
SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the
time it received the CB_RECALL.

Quoted 7 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries).
After that, we fall thru and nfsd4_cb_recall_done() returns -1 which
causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 4 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just
give up

Quoted 5 lines

That's what the patch is essentially doing. Or are you saying don't
even bother with the checks but still return 1 so we don't set the
SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 7 lines

Right, I don't see any point returning -1 (which ends up setting CB_PATH_DOWN) in any case where we get an nfs-level error. If the client got so far as returning an error, then the callback path is working.

I'm not sure exactly what errors *should* result in CB_PATH_DOWN, though. ETIMEDOUT, ENOTCONN, EIO?

I'm not sure either. Looking at call_status/call_timeout/rpc_check_timeout, it looks to me like ENOTCONN
will be translated to ETIMEDOUT because nfsd4_run_cb_work sets the RPC_TASK_SOFTCONN flag in the call to rpc_call_async.

Quoted 3 lines

It looks like call_status can return EHOSTDOWN, ENETDOWN, EHOSTUNREACH,
ENETUNREACH, and EPERM... should those be handled as well?

Those errors should never be passed back to applications.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]
#6 lore raw
Quoted 58 lines · Trond Myklebust
Quoted 57 lines · Scott Mayhew
Quoted 41 lines · J. Bruce Fields
Quoted 34 lines · Scott Mayhew
Quoted 12 lines · J. Bruce Fields
Quoted 10 lines · Scott Mayhew

While trying to track down some issues involving large numbers of
delegations being recalled/revoked, I caught the server setting
SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the
time it received the CB_RECALL.

Quoted 7 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries).
After that, we fall thru and nfsd4_cb_recall_done() returns -1 which
causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 4 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just
give up

Quoted 5 lines

That's what the patch is essentially doing. Or are you saying don't
even bother with the checks but still return 1 so we don't set the
SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 7 lines

Right, I don't see any point returning -1 (which ends up setting CB_PATH_DOWN) in any case where we get an nfs-level error. If the client got so far as returning an error, then the callback path is working.

I'm not sure exactly what errors *should* result in CB_PATH_DOWN, though. ETIMEDOUT, ENOTCONN, EIO?

I'm not sure either. Looking at call_status/call_timeout/rpc_check_timeout, it looks to me like ENOTCONN
will be translated to ETIMEDOUT because nfsd4_run_cb_work sets the RPC_TASK_SOFTCONN flag in the call to rpc_call_async.

Quoted 5 lines
Quoted 3 lines

It looks like call_status can return EHOSTDOWN, ENETDOWN, EHOSTUNREACH,
ENETUNREACH, and EPERM... should those be handled as well?

Those errors should never be passed back to applications.

I'm confused. If call_status passes any of those errors to rpc_exit, then I'll see them in rpc_call_done/nfsd4_cb_done, won't I?

-Scott

Quoted 7 lines
Signature · 4 lines
-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]
#7 lore raw
Quoted 71 lines · Scott Mayhew
Quoted 69 lines · Trond Myklebust
Quoted 68 lines · Scott Mayhew
Quoted 55 lines · J. Bruce Fields
Quoted 38 lines · Scott Mayhew
Quoted 15 lines · J. Bruce Fields
Quoted 4 lines · Scott Mayhew

While trying to track down some issues involving large numbers of
delegations being recalled/revoked, I caught the server setting

Quoted 8 lines

SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a
TEST_STATEID and FREE_STATEID for a delegation being recalled
by the
time it received the CB_RECALL.

Quoted 7 lines

That's interesting, thanks!

This exception seems awfully narrow, though.

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries).
After that, we fall thru and nfsd4_cb_recall_done() returns -1
which
causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 4 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just
give up

Quoted 7 lines

That's what the patch is essentially doing. Or are you saying
don't
even bother with the checks but still return 1 so we don't set
the
SEQ4_STATUS_CB_PATH_DOWN flag?

Right, I don't see any point returning -1 (which ends up setting
CB_PATH_DOWN) in any case where we get an nfs-level error. If the
client got so far as returning an error, then the callback path is
working.

Quoted 3 lines

I'm not sure exactly what errors *should* result in CB_PATH_DOWN,
though. ETIMEDOUT, ENOTCONN, EIO?

I'm not sure either. Looking at call_status/call_timeout/rpc_check_timeout, it looks to me like ENOTCONN
will be translated to ETIMEDOUT because nfsd4_run_cb_work sets the
RPC_TASK_SOFTCONN flag in the call to rpc_call_async.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

It looks like call_status can return EHOSTDOWN, ENETDOWN, EHOSTUNREACH,
ENETUNREACH, and EPERM... should those be handled as well?

Those errors should never be passed back to applications.

I'm confused. If call_status passes any of those errors to rpc_exit, then I'll see them in rpc_call_done/nfsd4_cb_done, won't I?

If you ever see them in rpc_call_done/nfsd4_cb_done, then it will be due to an RPC bug which will need to be fixed.

call_status() should be handling those errors by retrying, and if it runs out of retry attempts, then it should be setting either an EIO error or an ETIMEDOUT error, depending on which rpc_task flags have been specified.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]
#8 lore raw
In reply to Scott Mayhew
Quoted 16 lines · Scott Mayhew
Quoted 14 lines · J. Bruce Fields
Quoted 8 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the
time it received the CB_RECALL.

That's interesting, thanks!

This exception seems awfully narrow, though.

Quoted 8 lines
Quoted 3 lines

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

There is no handling of NFS4ERR_DELAY in nfsd4_cb_recall_done().

As far as I can see, therefore, if the client returns NFS4ERR_DELAY (which it usually does if it is already in the process of returning the delegation) then the recall will fail immediately.

Quoted 12 lines
Quoted 4 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just
give up

That's what the patch is essentially doing. Or are you saying don't even bother with the checks but still return 1 so we don't set the SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 2 lines

and let the client deal with the ensuing
RECALLABLE_STATE_REVOKED flag.

Quoted 7 lines

The client's already dealing with the RECALLABLE_STATE_REVOKED flag, that's why it sent a TEST_STATEID and FREE_STATEID before it got this particular CB_RECALL. The idea behind the patch is to not give the state manager on the client additional work by setting CB_PATH_DOWN when
the callback channel is clearly working...

Either way, the Linux client will ignore any further sequence flags until it is done with the recovery of the RECALLABLE_STATE_REVOKED flag. The reason is that the flags are edge triggered (i.e. they don't clear until the state changes), and so we need to be able to perform a full recovery before we can check them again.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]
#9 lore raw
Quoted 26 lines · Trond Myklebust
Quoted 16 lines · Scott Mayhew
Quoted 14 lines · J. Bruce Fields
Quoted 8 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the
time it received the CB_RECALL.

That's interesting, thanks!

This exception seems awfully narrow, though.

Quoted 8 lines
Quoted 3 lines

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 5 lines

There is no handling of NFS4ERR_DELAY in nfsd4_cb_recall_done().

As far as I can see, therefore, if the client returns NFS4ERR_DELAY (which it usually does if it is already in the process of returning the delegation) then the recall will fail immediately.

We should fix that, though it doesn't sound like it matters much in that particular case.

The success or failure of a recall isn't actually all that interesting, all that matters is whether we get the eventual DELEGRETURN.

--b.

#10 lore raw
In reply to Trond Myklebust
Quoted 26 lines · Trond Myklebust
Quoted 16 lines · Scott Mayhew
Quoted 14 lines · J. Bruce Fields
Quoted 8 lines · Scott Mayhew

While trying to track down some issues involving large numbers of delegations being recalled/revoked, I caught the server setting SEQ4_STATUS_CB_PATH_DOWN while the client was actively responding to
CB_RECALLs. It turns out that the client had already done a TEST_STATEID and FREE_STATEID for a delegation being recalled by the
time it received the CB_RECALL.

That's interesting, thanks!

This exception seems awfully narrow, though.

Quoted 8 lines
Quoted 3 lines

If we get back any NFS-level error at all, then I think the callback
channel is working (am I wrong?)

Correct, if the client replies with either NFS4ERR_DELAY or NFS4ERR_BAD_STATEID, the server will retry 1 time (see dl_retries). After that, we fall thru and nfsd4_cb_recall_done() returns -1 which causes the SEQ4_STATUS_CB_PATH_DOWN flag to be set.

Quoted 5 lines

There is no handling of NFS4ERR_DELAY in nfsd4_cb_recall_done().

As far as I can see, therefore, if the client returns NFS4ERR_DELAY (which it usually does if it is already in the process of returning the delegation) then the recall will fail immediately.

You're right, I had NFS4ERR_DELAY on the brain because I was seeing those periodically in conjunction with the BIND_CONN_TO_SESSION calls that were occurring while handling the bogus CB_PATH_DOWN flags from the server.

-Scott

Quoted 33 lines
Quoted 13 lines
Quoted 5 lines

and telling the client to set up a new
one is probably not going to help. The best we can do is probably just
give up

That's what the patch is essentially doing. Or are you saying don't even bother with the checks but still return 1 so we don't set the SEQ4_STATUS_CB_PATH_DOWN flag?

Quoted 2 lines

and let the client deal with the ensuing
RECALLABLE_STATE_REVOKED flag.

Quoted 7 lines

The client's already dealing with the RECALLABLE_STATE_REVOKED flag, that's why it sent a TEST_STATEID and FREE_STATEID before it got this particular CB_RECALL. The idea behind the patch is to not give the state manager on the client additional work by setting CB_PATH_DOWN when
the callback channel is clearly working...

Either way, the Linux client will ignore any further sequence flags until it is done with the recovery of the RECALLABLE_STATE_REVOKED flag. The reason is that the flags are edge triggered (i.e. they don't clear until the state changes), and so we need to be able to perform a full recovery before we can check them again.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]