Skip to contentSkip to conversation

kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build

next Sergey Senozhatsky 3 participants 3 messages Apr 19, 2019

lore
Share & tools
lore
#0 lore raw

Hello Masahiro,

It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh on my system. It scans, basically, my entire drive now (including the root partition):

$ ./scripts/tags.sh tags
find: ‘/arch/*.[chS]/’: No such file or directory
find: ‘/include’: No such file or directory
find: ‘/boot/lost+found’: Permission denied
find: ‘/etc/pacman.d/gnupg/openpgp-revocs.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/private-keys-v1.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/crls.d’: Permission denied
find: ‘/etc/polkit-1/rules.d’: Permission denied
find: ‘/etc/sudoers.d’: Permission denied
find: ‘/etc/audisp/plugins.d’: Permission denied
find: ‘/home/lost+found’: Permission denied
find: ‘/home/sk’: Permission denied
find: ‘/lost+found’: Permission denied
ctags: Warning: --extra option is obsolete; use --extras instead
[..]

With reverted a9a49c2ad9b9b8 tags scans kernel source tree only

./scripts/tags.sh tags
find: ‘arch/*.[chS]/’: No such file or directory
ctags: Warning: --extra option is obsolete; use --extras instead [..]

	-ss
#1 lore raw

Hi Sergey,

Quoted 9 lines

-----Original Message-----
From: Sergey Senozhatsky [mailto:[email protected]]
Sent: Friday, April 19, 2019 5:34 PM
To: Yamada, Masahiro/山田 真弘 <[email protected]>
Cc: [email protected]; Sergey Senozhatsky <[email protected]>
Subject: [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build

Quoted 7 lines

Hello Masahiro,

It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh on my system. It scans, basically, my entire drive now (including the root partition):

$ ./scripts/tags.sh tags

I did not know this script is run directly
because I expected people were using 'make tags'.

It is easy to fix, though.

scripts/tags.sh +1 -1
index 6a551805db52..70e14c67bde7 100755
@@ -19,7 +19,7 @@ ignore="$ignore ( -name *.mod.c ) -prune -o"
 # Do not use full path if we do not use O=.. builds
 # Use make O=. {tags|cscope}
 # to force full paths for a non-O= build
-if [ "${srctree}" = "." ]; then
+if [ "${srctree}" = "." -o -z "${srctree}" ]; then
        tree=
 else
        tree=${srctree}/
Quoted 24 lines

find: ‘/arch/*.[chS]/’: No such file or directory
find: ‘/include’: No such file or directory
find: ‘/boot/lost+found’: Permission denied
find: ‘/etc/pacman.d/gnupg/openpgp-revocs.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/private-keys-v1.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/crls.d’: Permission denied
find: ‘/etc/polkit-1/rules.d’: Permission denied
find: ‘/etc/sudoers.d’: Permission denied
find: ‘/etc/audisp/plugins.d’: Permission denied
find: ‘/home/lost+found’: Permission denied
find: ‘/home/sk’: Permission denied
find: ‘/lost+found’: Permission denied
ctags: Warning: --extra option is obsolete; use --extras instead [..]

With reverted a9a49c2ad9b9b8 tags scans kernel source tree only

./scripts/tags.sh tags
find: ‘arch/*.[chS]/’: No such file or directory
ctags: Warning: --extra option is obsolete; use --extras instead [..]

	-ss
#2 lore raw
Quoted 8 lines · On (04/19/19 08:59), [email protected] wrote:
Quoted 5 lines

It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh on my system. It scans, basically, my entire drive now (including the root partition):

$ ./scripts/tags.sh tags

I did not know this script is run directly
because I expected people were using 'make tags'.

:) I always run it directly, didn't even know there was 'make tags'

Quoted 1 line

It is easy to fix, though.

Works fine.

	-ss