Skip to contentSkip to conversation

arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3

PATCH Applied Yangtao Li 3 participants 5 messages Apr 20, 2019 – May 7, 2019

Subsystems (2)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3

Orangepi 3 has HDMI type A connector.

---
rebase:
sunxi/dt64-for-5.2 arm64: dts: allwinner: a64-amarula-relic: Add OV5640 camera node

---
 .../dts/allwinner/sun50i-h6-orangepi-3.dts    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts +25 -0
index 17d496990108..6ed3a1ee297d 100644
@@ -21,6 +21,17 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -50,6 +61,10 @@
 	cpu-supply = <&reg_dcdca>;
 };
 
+&de {
+	status = "okay";
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -58,6 +73,16 @@
 	status = "okay";
 };
 
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
 &mmc0 {
 	vmmc-supply = <&reg_cldo1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
Signature · 1 line
2.17.0
#2 lore raw

Hi Maxime,

Quoted 7 lines · Maxime Ripard
Quoted 3 lines · Yangtao Li

Orangepi 3 has HDMI type A connector.

Queued for 5.3, thanks!
Maxime

This patch is not enough. HDMI support on Orange Pi 3 also needs to enable DDC IO. While the SoC will feed some default output singal into the display, without DDC enabled it will not work reliably.

That support is part of my Orange Pi 3 series, and will be reworked for v5 of that series.

While I can rebase on top of this, it would be easier if you dropped this patch until the propper support is ready. I don't see any reason why this should be rushed with half-working solution.

regards,

	o.
Quoted 11 lines

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
In reply to Yangtao Li

Hi Yangtao,

Quoted 1 line · Yangtao Li

Orangepi 3 has HDMI type A connector.

It also has DDC-IO-EN, whithout which HDMI will not work as expected by most users.

I'm working on a proper solution (discussion here):

https://lkml.org/lkml/2019/4/26/910

regards,

	o.
Quoted 67 lines

---
rebase:
sunxi/dt64-for-5.2 arm64: dts: allwinner: a64-amarula-relic: Add OV5640 camera node

---
 .../dts/allwinner/sun50i-h6-orangepi-3.dts    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts +25 -0
index 17d496990108..6ed3a1ee297d 100644
@@ -21,6 +21,17 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -50,6 +61,10 @@
 	cpu-supply = <&reg_dcdca>;
 };
 
+&de {
+	status = "okay";
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -58,6 +73,16 @@
 	status = "okay";
 };
 
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
 &mmc0 {
 	vmmc-supply = <&reg_cldo1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
Signature · 7 lines
2.17.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw
In reply to Ondřej Jirman
Quoted 15 lines · Ondřej Jirman

Hi Maxime,

Quoted 7 lines · Maxime Ripard
Quoted 3 lines · Yangtao Li

Orangepi 3 has HDMI type A connector.

Queued for 5.3, thanks!
Maxime

This patch is not enough. HDMI support on Orange Pi 3 also needs to enable DDC IO. While the SoC will feed some default output singal into the display, without DDC enabled it will not work reliably.

Quoted 6 lines

That support is part of my Orange Pi 3 series, and will be reworked for v5 of that series.

While I can rebase on top of this, it would be easier if you dropped this patch until the propper support is ready. I don't see any reason why this should be rushed with half-working solution.

ACK, consider it dropped.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com