Skip to contentSkip to conversation

kdb: kdb_support: replace strcpy() by strscpy()

PATCH New Gustavo A. R. Silva 1 participant 1 message Apr 22, 2019 KGDB / KDB /debug_core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kdb: kdb_support: replace strcpy() by strscpy()

The strcpy() function is being deprecated. Replace it by the safer strscpy() and fix the following Coverity warning:

"You might overrun the 129-character fixed-size string ks_namebuf by copying name without checking the length."

Addresses-Coverity-ID: 138995 ("Copy into fixed size buffer")

---
 kernel/debug/kdb/kdb_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/kdb/kdb_support.c +1 -1
index 50bf9b119bad..b8e6306e7e13 100644
@@ -192,7 +192,7 @@ int kallsyms_symbol_complete(char *prefix_name, int max_len)
 
 	while ((name = kdb_walk_kallsyms(&pos))) {
 		if (strncmp(name, prefix_name, prefix_len) == 0) {
-			strcpy(ks_namebuf, name);
+			strscpy(ks_namebuf, name, sizeof(ks_namebuf));
 			/* Work out the longest name that matches the prefix */
 			if (++number == 1) {
 				prev_len = min_t(int, max_len-1,
Signature · 1 line
2.21.0