gdbstub: Replace strcpy() by strscpy()
PATCH 1/1 gdbstub: Replace strcpy() by strscpy()
The strcpy() function is being deprecated. Replace it by the safer strscpy() and fix the following Coverity warning:
"You might overrun the 1024-character fixed-size string remcom_in_buffer by copying cmd without checking the length."
Addresses-Coverity-ID: 138999 ("Copy into fixed size buffer")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- kernel/debug/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/debug/gdbstub.c +2 -2
@@ -1094,10 +1094,10 @@ int gdbstub_state(struct kgdb_state *ks, char *cmd)return error;case 's' :case 'c' : -strcpy (remcom_in_buffer, cmd); +strscpy (remcom_in_buffer, cmd,sizeof (remcom_in_buffer));return 0 ;case '$' : -strcpy (remcom_in_buffer, cmd); +strscpy (remcom_in_buffer, cmd,sizeof (remcom_in_buffer)); gdbstub_use_prev_in_buf =strlen (remcom_in_buffer); gdbstub_prev_in_buf_pos =0 ;return 0 ;
Signature · 1 line
2.21.0