Skip to contentSkip to conversation

nds32: vdso: drop unnecessary cc-ldoption

PATCH In review Nick Desaulniers 3 participants 4 messages Apr 23, 2019 – Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nds32: vdso: drop unnecessary cc-ldoption

Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20.

---
 arch/nds32/kernel/vdso/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/nds32/kernel/vdso/Makefile +2 -4
index e6c50a701313..d379645cad74 100644
@@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
 targets := $(obj-vdso) vdso.so vdso.so.dbg
 obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
 
-ccflags-y := -shared -fno-common -fno-builtin
-ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
-		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
-ccflags-y += -fPIC -Wl,-shared -g
+ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
+	-Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
 
 # Disable gcov profiling for VDSO code
 GCOV_PROFILE := n
Signature · 1 line
2.21.0.593.g511ec345e18-goog
Acked-by on v1 1/1
#1 lore raw

Hi Nick & Yamada,

Nick Desaulniers <[email protected]> 於 2019年4月24日 週三 上午5:19寫道:

Quoted 21 lines

Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20.

---
 arch/nds32/kernel/vdso/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/nds32/kernel/vdso/Makefile +0 -0
index e6c50a701313..d379645cad74 100644
@@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
 targets := $(obj-vdso) vdso.so vdso.so.dbg
 obj-vdso := $(addprefix $(obj)/, $(obj-vdso))

arch/nds32/kernel/vdso/Makefile obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o · line 18

Quoted 10 lines
arch/nds32/kernel/vdso/Makefile +2 -4
 
-ccflags-y := -shared -fno-common -fno-builtin
-ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
-               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
-ccflags-y += -fPIC -Wl,-shared -g
+ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
+       -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
 
 # Disable gcov profiling for VDSO code
 GCOV_PROFILE := n

Thank you.

#2 lore raw
Quoted 33 lines · Greentime Hu

Hi Nick & Yamada,

Nick Desaulniers <[email protected]> 於 2019年4月24日 週三 上午5:19寫道:

Quoted 29 lines

Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20.

---
 arch/nds32/kernel/vdso/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/nds32/kernel/vdso/Makefile +2 -4
index e6c50a701313..d379645cad74 100644
@@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
 targets := $(obj-vdso) vdso.so vdso.so.dbg
 obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
 
-ccflags-y := -shared -fno-common -fno-builtin
-ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
-               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
-ccflags-y += -fPIC -Wl,-shared -g
+ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
+       -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
 
Quoted 5 lines

arch/nds32/kernel/vdso/Makefile obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o · line 18

Quoted 2 lines
arch/nds32/kernel/vdso/Makefile +0 -0
 # Disable gcov profiling for VDSO code
 GCOV_PROFILE := n

Thank you.

Who do you expect to pick up this patch?

You are the NDS32 maintainer
according to MAINTAINERS.

ANDES ARCHITECTURE

M:      Greentime Hu <[email protected]>
M:      Vincent Chen <[email protected]>
T:      git https://github.com/andestech/linux.git
S:      Supported
F:      arch/nds32/
F:      Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
F:      Documentation/devicetree/bindings/nds32/
K:      nds32
N:      nds32

You do not maintain https://github.com/andestech/linux.git any more, do you?

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw

Masahiro Yamada <[email protected]> 於 2019年4月24日 週三 下午3:54寫道:

Quoted 60 lines · Greentime Hu
Quoted 33 lines

Hi Nick & Yamada,

Nick Desaulniers <[email protected]> 於 2019年4月24日 週三 上午5:19寫道:

Quoted 29 lines

Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20.

---
 arch/nds32/kernel/vdso/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/nds32/kernel/vdso/Makefile +2 -4
index e6c50a701313..d379645cad74 100644
@@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
 targets := $(obj-vdso) vdso.so vdso.so.dbg
 obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
 
-ccflags-y := -shared -fno-common -fno-builtin
-ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
-               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
-ccflags-y += -fPIC -Wl,-shared -g
+ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
+       -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
 
Quoted 5 lines

arch/nds32/kernel/vdso/Makefile obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o · line 18

Quoted 2 lines
arch/nds32/kernel/vdso/Makefile +0 -0
 # Disable gcov profiling for VDSO code
 GCOV_PROFILE := n

Thank you.

Who do you expect to pick up this patch?

You are the NDS32 maintainer
according to MAINTAINERS.

ANDES ARCHITECTURE

M:      Greentime Hu <[email protected]>
M:      Vincent Chen <[email protected]>
T:      git https://github.com/andestech/linux.git
S:      Supported
F:      arch/nds32/
F:      Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
F:      Documentation/devicetree/bindings/nds32/
K:      nds32
N:      nds32
Quoted 1 line

You do not maintain https://github.com/andestech/linux.git any more, do you?

Hi Yamada,

I think I should update this MAINTAINERS file.
I will pick it in this repo
https://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux.git