mlxsw: spectrum_router: Prevent ipv6 gateway with v4 route via replace and append
Subsystems (3)
PATCH v2 1/1 mlxsw: spectrum_router: Prevent ipv6 gateway with v4 route via replace and append
From: David Ahern <[email protected]>
mlxsw currently does not support v6 gateways with v4 routes. Commit 19a9d136f198 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway") prevents a route from being added, but nothing stops the replace or append. Add a catch for them too.
$ ip ro add 172.16.2.0/24 via 10.99.1.2
$ ip ro replace 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0
Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported.
$ ip ro append 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0
Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported.---
v2
- added catch for append and moved up location to ADD case
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +2 -0
@@ -6105,6 +6105,8 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb,return notifier_from_errno (err);break ;case FIB_EVENT_ENTRY_ADD : +case FIB_EVENT_ENTRY_REPLACE :/* fall through */ +case FIB_EVENT_ENTRY_APPEND :/* fall through */ if (router->aborted) {NL_SET_ERR_MSG_MOD (info->extack,"FIB offload was aborted. Not configuring route" );return notifier_from_errno (-EINVAL );
Signature · 1 line
2.11.0
From: David Ahern <[email protected]>
Date: Tue, 23 Apr 2019 16:03:29 -0700
Quoted 12 lines
From: David Ahern <[email protected]>
mlxsw currently does not support v6 gateways with v4 routes. Commit
19a9d136f198("ipv4: Flagfib_infowith afib_nhusing IPv6 gateway") prevents a route from being added, but nothing stops the replace or append. Add a catch for them too.$ ip ro add 172.16.2.0/24 via 10.99.1.2 $ ip ro replace 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0 Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported. $ ip ro append 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0 Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported.
Quoted 4 lines
Signed-off-by David Ahern <[email protected]>---
v2
- added catch for append and moved up location to ADD case
Applied, thanks David.