Skip to contentSkip to conversation

lkdtm: fix potential use after free

PATCH In review Weikang shi 2 participants 2 messages Apr 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lkdtm: fix potential use after free

From: swkhack <[email protected]>

The function lkdtm_WRITE_AFTER_FREE calls kfree(base) to free the memory
of base. However, following kfree(base),
it write the memory which base point to via base[offset] = 0x0abcdef0. This may result in a use-after-free bug. This patch moves kfree(base) after the write.

---
 drivers/misc/lkdtm/heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/lkdtm/heap.c +1 -1
index 65026d7de..0b9141525 100644
@@ -40,8 +40,8 @@ void lkdtm_WRITE_AFTER_FREE(void)
 	pr_info("Allocated memory %p-%p\n", base, &base[offset * 2]);
 	pr_info("Attempting bad write to freed memory at %p\n",
 		&base[offset]);
-	kfree(base);
 	base[offset] = 0x0abcdef0;
+	kfree(base);
 	/* Attempt to notice the overwrite. */
 	again = kmalloc(len, GFP_KERNEL);
 	kfree(again);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Weikang shi

From: swkhack <[email protected]>

The function lkdtm_WRITE_AFTER_FREE calls kfree(base) to free the memory
of base. However, following kfree(base),
it write the memory which base point to via base[offset] = 0x0abcdef0. This may result in a use-after-free bug. This patch moves kfree(base) after the write.

As with lkdtm_READ_AFTER_FREE, this is deliberate, and we should not make this change.

Thanks,
Mark.

Quoted 23 lines
---
 drivers/misc/lkdtm/heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/lkdtm/heap.c +1 -1
index 65026d7de..0b9141525 100644
@@ -40,8 +40,8 @@ void lkdtm_WRITE_AFTER_FREE(void)
 	pr_info("Allocated memory %p-%p\n", base, &base[offset * 2]);
 	pr_info("Attempting bad write to freed memory at %p\n",
 		&base[offset]);
-	kfree(base);
 	base[offset] = 0x0abcdef0;
+	kfree(base);
 	/* Attempt to notice the overwrite. */
 	again = kmalloc(len, GFP_KERNEL);
 	kfree(again);
Signature · 1 line
2.17.1