Skip to contentSkip to conversation

buildhistory: call a dependency parser only on actual dependency lists

PATCH In review Alexander Kanavin 2 participants 2 messages Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildhistory: call a dependency parser only on actual dependency lists

Previously it was also called on filelists and possibly other items which broke the parser.

---
 meta/lib/oe/buildhistory_analysis.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/buildhistory_analysis.py +1 -1
index ad7fceb8bbc..d3cde4f6509 100644
@@ -127,7 +127,7 @@ class ChangeRecord:
             removed = list(set(aitems) - set(bitems))
             added = list(set(bitems) - set(aitems))
 
-            if not removed and not added:
+            if not removed and not added and self.fieldname in ['RPROVIDES', 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RREPLACES', 'RCONFLICTS']:
                 depvera = bb.utils.explode_dep_versions2(self.oldvalue, sort=False)
                 depverb = bb.utils.explode_dep_versions2(self.newvalue, sort=False)
                 for i, j in zip(depvera.items(), depverb.items()):
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Alexander Kanavin

Previously it was also called on filelists and possibly other items which broke the parser.

Thanks, that fix makes sense, I couldn't see the wood for the trees! :)

Cheers,

Richard