iommu/amd: flush not present cache in iommu_map_page
PATCH 1/1 iommu/amd: flush not present cache in iommu_map_page
check if there is a not-present cache present and flush it if there is.
--- drivers/iommu/amd_iommu.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/iommu/amd_iommu.c +5 -0
@@ -1637,6 +1637,11 @@ static int iommu_map_page(struct protection_domain *dom,update_domain (dom); +if (unlikely (amd_iommu_np_cache && !dom->updated)) { +domain_flush_pages (dom, bus_addr, page_size); +domain_flush_complete (dom); + } +/* Everything flushed out, free pages now */ free_page_list (freelist);
Signature · 1 line
2.17.1
Joerg Roedel
maintainerQuoted 12 lines · Tom Murphy
check if there is a not-present cache present and flush it if there is.
Signed-off-by Tom Murphy <[email protected]>--- drivers/iommu/amd_iommu.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/iommu/amd_iommu.c +0
-0
drivers/iommu/amd_iommu.c static int iommu_map_page(struct protection_domain *dom, · line 1644
Quoted 8 lines
drivers/iommu/amd_iommu.c +5
-0@@ -1637,6 +1637,11 @@ static int iommu_map_page(struct protection_domain *dom,update_domain (dom); +if (unlikely (amd_iommu_np_cache && !dom->updated)) { +domain_flush_pages (dom, bus_addr, page_size); +domain_flush_complete (dom); + } +
The iommu_map_page function is called once per physical page that is mapped, so in the worst case for every 4k mapping established. So it is not the right place to put this check in.
Quoted 1 line
From a quick glance this check belongs into the
map_sg()and the
amd_iommu_map() function, but without the dom->updated check.
Besides, to really support systems with np-cache in a way that doesn't destroy all performance, the driver also needs range-flushes for IOTLBs. Currently it can only flush a 4k page of the full address space of a domain. But that doesn't mean we shouldn't fix the missing flushes now.
So please re-send the patch with the check at the two places I pointed out above.
Thanks,
Joerg
Quoted 3 lines
The
iommu_map_pagefunction is called once per physical page that is mapped, so in the worst case for every 4k mapping established. So it is not the right place to put this check in.
Ah, you're right, that was careless of me.
Quoted 5 lines
From a quick glance this check belongs into the
map_sg()and theamd_iommu_map()function, but without thedom->updatedcheck.Besides, to really support systems with np-cache in a way that doesn't destroy all performance, the driver also needs range-flushes for IOTLBs.
I am working on another patch to improve the intel iotlb flushing in the iommu ops patch which should cover this too.
Quoted 5 lines
Currently it can only flush a 4k page of the full address space of a domain. But that doesn't mean we shouldn't fix the missing flushes now.
So please re-send the patch with the check at the two places I pointed out above.
will do
Quoted 2 lines · Tom Murphy
I am working on another patch to improve the intel iotlb flushing in the iommu ops patch which should cover this too.
So are you looking into converting the intel-iommu driver to use dma-iommu as well? That would be great!
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Tom Murphy
I am working on another patch to improve the intel iotlb flushing in the iommu ops patch which should cover this too.
So are you looking into converting the intel-iommu driver to use dma-iommu as well? That would be great!
Yes. My patches depend on the "iommu/vt-d: Delegate DMA domain to generic iommu" patch which is currently being reviewed.
Quoted 2 lines · Tom Murphy
Yes. My patches depend on the "iommu/vt-d: Delegate DMA domain to generic iommu" patch which is currently being reviewed.
Nice!