dt-bindings: phy: tegra-xusb: List PLL power supplies
Subsystems (4)
PATCH 1/3 dt-bindings: phy: tegra-xusb: List PLL power supplies
From: Thierry Reding <[email protected]>
These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail.
---
This was previously reviewed here:
https://patchwork.ozlabs.org/patch/1077153/
.../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt +12 -0
@@ -42,6 +42,18 @@ Required properties: - reset-names: Must include the following entries: - "padctl" +For Tegra124: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V. + +For Tegra210: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V. + For Tegra186: - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY power supply. Must supply 1.8 V.
Signature · 1 line
2.21.0
PATCH 2/3 phy: tegra: xusb: Add Tegra124 PLL power supplies
From: Thierry Reding <[email protected]>
The Tegra124 SoC has four inputs that consume power in order to supply the PLLs that drive the various USB, PCI and SATA pads.
--- drivers/phy/tegra/xusb-tegra124.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/phy/tegra/xusb-tegra124.c +9 -0
@@ -1721,6 +1721,13 @@ static const struct tegra_xusb_padctl_ops tegra124_xusb_padctl_ops = { .hsic_set_idle = tegra124_hsic_set_idle, }; +static const char *const tegra124_xusb_padctl_supply_names[] = { +"avdd-pll-utmip" , +"avdd-pll-erefe" , +"avdd-pex-pll" , +"hvdd-pex-pll-e" , +}; +const struct tegra_xusb_padctl_soc tegra124_xusb_padctl_soc = { .num_pads =ARRAY_SIZE (tegra124_pads), .pads = tegra124_pads,
@@ -1743,6 +1750,8 @@ const struct tegra_xusb_padctl_soc tegra124_xusb_padctl_soc = { }, }, .ops = &tegra124_xusb_padctl_ops, + .supply_names = tegra124_xusb_padctl_supply_names, + .num_supplies = ARRAY_SIZE(tegra124_xusb_padctl_supply_names), };EXPORT_SYMBOL_GPL (tegra124_xusb_padctl_soc);
Signature · 1 line
2.21.0
PATCH 3/3 phy: tegra: xusb: Add Tegra210 PLL power supplies
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The Tegra210 SoC has four inputs that consume power in order to supply the PLLs that drive the various USB, PCI and SATA pads.
--- drivers/phy/tegra/xusb-tegra210.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/phy/tegra/xusb-tegra210.c +9 -0
@@ -2017,6 +2017,13 @@ static const struct tegra_xusb_padctl_ops tegra210_xusb_padctl_ops = { .hsic_set_idle = tegra210_hsic_set_idle, }; +static const char *const tegra210_xusb_padctl_supply_names[] = { +"avdd-pll-utmip" , +"avdd-pll-uerefe" , +"dvdd-pex-pll" , +"hvdd-pex-pll-e" , +}; +const struct tegra_xusb_padctl_soc tegra210_xusb_padctl_soc = { .num_pads =ARRAY_SIZE (tegra210_pads), .pads = tegra210_pads,
@@ -2035,6 +2042,8 @@ const struct tegra_xusb_padctl_soc tegra210_xusb_padctl_soc = { }, }, .ops = &tegra210_xusb_padctl_ops, + .supply_names = tegra210_xusb_padctl_supply_names, + .num_supplies = ARRAY_SIZE(tegra210_xusb_padctl_supply_names), };EXPORT_SYMBOL_GPL (tegra210_xusb_padctl_soc);
Signature · 1 line
2.21.0
Quoted 10 lines · Thierry Reding
From: Thierry Reding <[email protected]>
These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Thierry Reding <[email protected]>
For the series ...
Cheers
Jon
Signature · 1 line
nvpublic
Quoted 10 lines · Thierry Reding
From: Thierry Reding <[email protected]>
These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Thierry Reding <[email protected]>
Quoted 7 lines
---
This was previously reviewed here:https://patchwork.ozlabs.org/patch/1077153/.../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Hi Kishon,
do you have any comments on this series. It's fairly straightforward but is required in order to make XUSB work properly on Jetson Nano for which support was merged in v5.2-rc1.
Thanks,
Thierry
Quoted 27 lines
Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt +12
-0@@ -42,6 +42,18 @@ Required properties: - reset-names: Must include the following entries: - "padctl" +For Tegra124: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V. + +For Tegra210: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V. + For Tegra186: - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY power supply. Must supply 1.8 V.Signature · 1 line
2.21.0