ASoC: Intel: Skylake: change list empty check to warning
Subsystems (3)
PATCH 1/1 ASoC: Intel: Skylake: change list empty check to warning
NULL is a valid state for the module list when querying unique ID. Downgrade the empty condition from error to warning.
Signed-off-by Patrick Waterlander <[email protected]>
sound/soc/intel/skylake/skl-sst.c +1 -1
@@ -324,7 +324,7 @@ static struct skl_module_table *skl_module_get_from_id(struct skl_module_table *module;if (list_empty (&ctx->module_list)) { -dev_err (ctx->dev,"Module list is empty\n" ); +dev_warn (ctx->dev,"Module list is empty\n" );return NULL ; }
Signature · 1 line
2.17.1
Quoted 10 lines · Patrick Waterlander
NULL is a valid state for the module list when querying unique ID. Downgrade the empty condition from error to warning.
Signed-off-by Patrick Waterlander <[email protected]>sound/soc/intel/skylake/skl-sst.c +0
-0
sound/soc/intel/skylake/skl-sst.c static struct skl_module_table *skl_module_get_from_id( · line 327
Quoted 5 lines
sound/soc/intel/skylake/skl-sst.c +1
-1@@ -324,7 +324,7 @@ static struct skl_module_table *skl_module_get_from_id(struct skl_module_table *module;if (list_empty (&ctx->module_list)) { -dev_err (ctx->dev,"Module list is empty\n" ); +dev_warn (ctx->dev,"Module list is empty\n" );
Not sure what you are trying to fix here? Either it's an error and we can keep the message as is or it's not and that trace should go away. Changing the level doesn't really add much value, does it?
You should run this by Filip's team (CC:ed) and copy maintainers.
Quoted 4 lines
sound/soc/intel/skylake/skl-sst.c +0
-0return NULL ; }