tty: drop unused iflag macro
Subsystems (2)
PATCH 3/3 tty: cpm_uart: drop unused iflag macro
In reply to Johan HovoldDrop the RELEVANT_IFLAG() macro which hasn't been used at least since the dawn of git.
--- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 -- 1 file changed, 2 deletions(-)
drivers/tty/serial/cpm_uart/cpm_uart_core.c +0 -2
@@ -567,8 +567,6 @@ static void cpm_uart_set_termios(struct uart_port *port,/* * Set up parity check flag */ -#define RELEVANT_IFLAG (iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) - port->read_status_mask = (BD_SC_EMPTY |BD_SC_OV );if (termios->c_iflag &INPCK ) port->read_status_mask |=BD_SC_FR |BD_SC_PR ;
Signature · 1 line
2.21.0
PATCH 2/3 tty: ipoctal: drop unused iflag macro
In reply to Johan HovoldDrop the RELEVANT_IFLAG() macro which has never been used.
--- drivers/ipack/devices/ipoctal.h | 1 - 1 file changed, 1 deletion(-)
drivers/ipack/devices/ipoctal.h +0 -1
@@ -18,7 +18,6 @@#define NR_CHANNELS 8#define IPOCTAL_MAX_BOARDS 16#define MAX_DEVICES (NR_CHANNELS * IPOCTAL_MAX_BOARDS) -#define RELEVANT_IFLAG (iflag) ((iflag) & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))/** * struct ipoctal_stats -- Stats since last reset
Signature · 1 line
2.21.0
cover tty: drop unused iflag macro
I noticed that the RELEVANT_IFLAG() macro was unused in USB serial and turns out there were a few more instances that could be dropped.
I have some pending changes that may conflict with the corresponding change to USB serial so I'll take that one separately through my tree, but perhaps the rest could go through Greg's tty tree.
Johan
Johan Hovold (3):
tty: simserial: drop unused iflag macro
tty: ipoctal: drop unused iflag macro
tty: cpm_uart: drop unused iflag macro
arch/ia64/hp/sim/simserial.c | 2 -- drivers/ipack/devices/ipoctal.h | 1 - drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 -- 3 files changed, 5 deletions(-)
Signature · 1 line
2.21.0
PATCH 1/3 tty: simserial: drop unused iflag macro
Drop the RELEVANT_IFLAG() macro which hasn't been used for over a decade.
--- arch/ia64/hp/sim/simserial.c | 2 -- 1 file changed, 2 deletions(-)
arch/ia64/hp/sim/simserial.c +0 -2
@@ -324,8 +324,6 @@ static int rs_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg)return -ENOIOCTLCMD ; } -#define RELEVANT_IFLAG (iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) -/* * This routine will shutdown a serial port; interrupts are disabled, and * DTR is dropped if the hangup on close termio flag is on.
Signature · 1 line
2.21.0
RE: [PATCH 1/3] tty: simserial: drop unused iflag macro
Quoted 9 lines
Drop the
RELEVANT_IFLAG()macro which hasn't been used for over a decade.Cc Tony Luck <[email protected]>Cc Fenghua Yu <[email protected]>Signed-off-by Johan Hovold <[email protected]>--- arch/ia64/hp/sim/simserial.c | 2 -- 1 file changed, 2 deletions(-)
Quoted 12 lines · Johan Hovold
I noticed that the
RELEVANT_IFLAG()macro was unused in USB serial and turns out there were a few more instances that could be dropped.I have some pending changes that may conflict with the corresponding change to USB serial so I'll take that one separately through my tree, but perhaps the rest could go through Greg's tty tree.
Johan Hovold (3):
tty: simserial: drop unused iflag macro
tty: ipoctal: drop unused iflag macro
tty:cpm_uart: drop unused iflag macro
Quoted 4 lines
arch/ia64/hp/sim/simserial.c | 2 -- drivers/ipack/devices/ipoctal.h | 1 - drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 -- 3 files changed, 5 deletions(-)
Greg, do you still have these clean-ups in your queue? Want me to resend with Tony's ack?
Johan
Greg Kroah-Hartman
maintainerQuoted 13 lines · Johan Hovold
Quoted 12 lines · Johan Hovold
I noticed that the
RELEVANT_IFLAG()macro was unused in USB serial and turns out there were a few more instances that could be dropped.I have some pending changes that may conflict with the corresponding change to USB serial so I'll take that one separately through my tree, but perhaps the rest could go through Greg's tty tree.
Johan Hovold (3):
tty: simserial: drop unused iflag macro
tty: ipoctal: drop unused iflag macro
tty:cpm_uart: drop unused iflag macro
Quoted 7 lines
Quoted 4 lines
arch/ia64/hp/sim/simserial.c | 2 -- drivers/ipack/devices/ipoctal.h | 1 - drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 -- 3 files changed, 5 deletions(-)Greg, do you still have these clean-ups in your queue? Want me to resend with Tony's ack?
They are still in my to-review queue. Let me dig out from some more stable patches before I tackle the tty/serial stuff later today or tomorrow.
thanks,
greg k-h
Quoted 19 lines · Greg Kroah-Hartman
Quoted 18 lines · Johan Hovold
Quoted 16 lines · Johan Hovold
I noticed that the
RELEVANT_IFLAG()macro was unused in USB serial and turns out there were a few more instances that could be dropped.I have some pending changes that may conflict with the corresponding change to USB serial so I'll take that one separately through my tree, but perhaps the rest could go through Greg's tty tree.
Johan Hovold (3):
tty: simserial: drop unused iflag macro
tty: ipoctal: drop unused iflag macro
tty:cpm_uart: drop unused iflag macroarch/ia64/hp/sim/simserial.c | 2 -- drivers/ipack/devices/ipoctal.h | 1 - drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 -- 3 files changed, 5 deletions(-)
Quoted 6 lines
Quoted 2 lines
Greg, do you still have these clean-ups in your queue? Want me to resend with Tony's ack?
They are still in my to-review queue. Let me dig out from some more stable patches before I tackle the tty/serial stuff later today or tomorrow.
No rush. Just saw you applying some tty patches the other day so figured I'd ask. Thanks.
Johan