Skip to contentSkip to conversation

lib/igt_audio: fix filemode not specified in open(O_CREAT)

PATCH In review Simon Ser 3 participants 4 messages Apr 26, 2019 Library code

lore
Share & tools
lore

Simon Ser

author
#0 lore raw

PATCH 1/1 lib/igt_audio: fix filemode not specified in open(O_CREAT)

open(3) takes va_args after the flags and O_CREAT will read the first one. If we don't provide one, this is undefined behaviour.

(Someone reported it broke the build for them)

Signed-off-by Simon Ser <[email protected]>
Fixes 311baff151f90c1db6f57ee9515216b4f9da5db7
---
 lib/igt_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_audio.c +1 -1
index 5b0860e6..fd8cf07c 100644
@@ -447,7 +447,7 @@ int audio_create_wav_file_s32_le(const char *qualifier, uint32_t sample_rate,
 		*path = strdup(_path);
 
 	igt_debug("Dumping %s audio to %s\n", qualifier, _path);
-	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC);
+	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
 	if (fd < 0) {
 		igt_warn("open failed: %s\n", strerror(errno));
 		return -1;
Signature · 6 lines
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
CI
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_audio: fix filemode not specified in open(O_CREAT)

== Series Details ==

== Series Details ==

Series: lib/igt_audio: fix filemode not specified in open(O_CREAT)
URL : https://patchwork.freedesktop.org/series/59998/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6004 -> IGTPW_2928
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59998/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2928 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-cfl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#108126] / [fdo#108743])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/fi-cfl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/fi-cfl-guc/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][3] ([fdo#107718]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/fi-blb-e6850/igt@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- {fi-cml-u}: [FAIL][5] ([fdo#107383] / [fdo#110515]) -> [PASS][6] +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/fi-cml-u/igt@kms_psr@sprite_plane_onoff.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/fi-cml-u/igt@kms_psr@sprite_plane_onoff.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108126]: https://bugs.freedesktop.org/show_bug.cgi?id=108126
[fdo#108743]: https://bugs.freedesktop.org/show_bug.cgi?id=108743
[fdo#110515]: https://bugs.freedesktop.org/show_bug.cgi?id=110515

Participating hosts (39 -> 27)
------------------------------

Additional (4): fi-bdw-gvtdvm fi-byt-n2820 fi-icl-dsi fi-skl-gvtdvm
Missing (16): fi-kbl-soraka fi-ilk-m540 fi-skl-guc fi-icl-u2 fi-skl-6260u fi-bsw-cyan fi-kbl-guc fi-ctg-p8600 fi-kbl-x1275 fi-icl-u3 fi-bsw-kefka fi-skl-lmem fi-bdw-samus fi-byt-clapper fi-skl-6700k2 fi-kbl-r

Build changes
-------------

* IGT: IGT_4967 -> IGTPW_2928

CI_DRM_6004: f65fa2bd966e74a401abbf6b7e9b39c6e476c510 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2928: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/
IGT_4967: 1184e5778ac3ffd8caf3f4d5b9e2b30a736d64d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

CI
#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_audio: fix filemode not specified in open(O_CREAT)

In reply to Simon Ser
== Series Details ==

== Series Details ==

Series: lib/igt_audio: fix filemode not specified in open(O_CREAT)
URL : https://patchwork.freedesktop.org/series/59998/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6004_full -> IGTPW_2928_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59998/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2928_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@preempt-hang-bsd1:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([fdo#103313] / [fdo#103558] / [fdo#105602])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl7/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108686])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: [PASS][5] -> [FAIL][6] ([fdo#103167])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
- shard-kbl: [PASS][7] -> [FAIL][8] ([fdo#103167])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([fdo#103313] / [fdo#103558])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-hsw: [PASS][13] -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl3/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109642])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb2/igt@kms_psr2_su@page_flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb1/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#100047])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb1/igt@kms_sysfs_edid_timing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb3/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl5/igt@[email protected]

#### Possible fixes ####

* igt@gem_create@create-clear:
- shard-apl: [INCOMPLETE][25] ([fdo#103927]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl4/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl3/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-apl: [FAIL][31] ([fdo#103167]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-apl7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-apl1/igt@[email protected]
- shard-kbl: [FAIL][33] ([fdo#103167]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-kbl5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-kbl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][37] ([fdo#103166]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb2/igt@[email protected]

* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-glk: [SKIP][39] ([fdo#109271] / [fdo#109278]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-glk2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-glk9/igt@[email protected]

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb8/igt@kms_psr@psr2_sprite_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

#### Warnings ####

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-iclb: [INCOMPLETE][43] ([fdo#107713]) -> [SKIP][44] ([fdo#109280])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6004/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_4967 -> IGTPW_2928
* Piglit: piglit_4509 -> None

CI_DRM_6004: f65fa2bd966e74a401abbf6b7e9b39c6e476c510 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2928: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/
IGT_4967: 1184e5778ac3ffd8caf3f4d5b9e2b30a736d64d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2928/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#3 lore raw
In reply to Simon Ser

Quoting Simon Ser (2019-04-26 14:55:40)

Quoted 16 lines

open(3) takes va_args after the flags and O_CREAT will read the first one. If we don't provide one, this is undefined behaviour.

(Someone reported it broke the build for them)

Signed-off-by Simon Ser <[email protected]>
Fixes 311baff151f90c1db6f57ee9515216b4f9da5db7
---
 lib/igt_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_audio.c +0 -0
index 5b0860e6..fd8cf07c 100644

lib/igt_audio.c int audio_create_wav_file_s32_le(const char *qualifier, uint32_t sample_rate, · line 450

Quoted 5 lines
lib/igt_audio.c +1 -1
@@ -447,7 +447,7 @@ int audio_create_wav_file_s32_le(const char *qualifier, uint32_t sample_rate,
                *path = strdup(_path);
 
        igt_debug("Dumping %s audio to %s\n", qualifier, _path);
-       fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC);
+       fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC, 0644);

Ok,

Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev