Skip to contentSkip to conversation

dm-integrity: dont check null pointer before kvfree and vfree

PATCH In review Mikulas Patocka 1 participant 1 message Apr 29, 2019 Device mapper

lore
Share & tools
lore

Mikulas Patocka

author maintainer
#0 lore raw

PATCH 1/10 dm-integrity: dont check null pointer before kvfree and vfree

The functions kfree, vfree and kvfree do nothing if we pass a NULL pointer to them. So we don't need to test the pointer for NULL.

---
 drivers/md/dm-integrity.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/md/dm-integrity.c +2 -4
Index: linux-2.6/drivers/md/dm-integrity.c
===================================================================
@@ -3548,10 +3548,8 @@ static void dm_integrity_dtr(struct dm_t
 		destroy_workqueue(ic->writer_wq);
 	if (ic->recalc_wq)
 		destroy_workqueue(ic->recalc_wq);
-	if (ic->recalc_buffer)
-		vfree(ic->recalc_buffer);
-	if (ic->recalc_tags)
-		kvfree(ic->recalc_tags);
+	vfree(ic->recalc_buffer);
+	kvfree(ic->recalc_tags);
 	if (ic->bufio)
 		dm_bufio_client_destroy(ic->bufio);
 	mempool_exit(&ic->journal_io_mempool);