Skip to contentSkip to conversation

netfilter: nf_flow_table: check ttl value in flow offload data path

PATCH In review Taehee Yoo 1 participant 1 message Apr 29, 2019

Subsystems (2)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH v2 2/3 netfilter: nf_flow_table: check ttl value in flow offload data path

nf_flow_offload_ip_hook() and nf_flow_offload_ipv6_hook() do not check ttl value.
So, ttl value overflow can occur.

Fixes 97add9f0d66d ("netfilter: flow table support for IPv4")
Fixes 0995210753a2 ("netfilter: flow table support for IPv6")
---
 net/netfilter/nf_flow_table_ip.c | 6 ++++++
 1 file changed, 6 insertions(+)
net/netfilter/nf_flow_table_ip.c +6 -0
index 1d291a51cd45..46022a2867d7 100644
@@ -181,6 +181,9 @@ static int nf_flow_tuple_ip(struct sk_buff *skb, const struct net_device *dev,
 	    iph->protocol != IPPROTO_UDP)
 		return -1;
 
+	if (iph->ttl <= 1)
+		return -1;
+
 	thoff = iph->ihl * 4;
 	if (!pskb_may_pull(skb, thoff + sizeof(*ports)))
 		return -1;
@@ -411,6 +414,9 @@ static int nf_flow_tuple_ipv6(struct sk_buff *skb, const struct net_device *dev,
 	    ip6h->nexthdr != IPPROTO_UDP)
 		return -1;
 
+	if (ip6h->hop_limit <= 1)
+		return -1;
+
 	thoff = sizeof(*ip6h);
 	if (!pskb_may_pull(skb, thoff + sizeof(*ports)))
 		return -1;
Signature · 1 line
2.17.1