staging: kpc2000: Fix a stack information leak in kp2000_cdev_ioctl()

PATCH New Dan Carpenter 1 participant 1 message Apr 30, 2019

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2019-04-30 10:35 UTC #0 lore raw

PATCH 1/1 staging: kpc2000: Fix a stack information leak in kp2000_cdev_ioctl()

The kp2000_regs struct has a 4 byte hole between ->hw_rev and ->ssid so this could leak stack information to the user. This patch just memsets the whole struct to zero.

Fixes 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/staging/kpc2000/kpc2000/fileops.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/staging/kpc2000/kpc2000/fileops.c +2 -0

index 4bfba59570e6..a6beca8dbac5 100644
@@ -91,6 +91,8 @@ long  kp2000_cdev_ioctl(struct file *filp, unsigned int ioctl_num, unsigned long
 	case KP2000_IOCTL_GET_EVERYTHING: {
 		struct kp2000_regs temp;
 		int ret;
+
+		memset(&temp, 0, sizeof(temp));
 		temp.card_id = pcard->card_id;
 		temp.build_version = pcard->build_version;
 		temp.build_datestamp = pcard->build_datestamp;

Signature · 1 line

2.18.0