Skip to contentSkip to conversation

vfs: return EINVAL instead of ENOENT when missing source

PATCH RESEND In review Murphy Zhou 2 participants 3 messages May 1, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 vfs: return EINVAL instead of ENOENT when missing source

From: Xiong Zhou <[email protected]>

mount(2) with a NULL source device would return ENOENT instead of EINVAL after this commit:

commit f3a09c92018a91ad0981146a4ac59414f814d801

Author: Al Viro <[email protected]>
Date:   Sun Dec 23 18:55:56 2018 -0500

introduce fs_context methods

Change the return value to be compatible with the old behaviour.

This was caught by LTP mount02[1]. This testcase is calling mount(2) with a NULL device name and expecting EINVAL to PASS but now we are getting ENOENT.

[1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/mount/mount02.c

---
 fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/super.c +1 -1
index 583a0124bc39..48e51f13a4ba 100644
@@ -1469,7 +1469,7 @@ int vfs_get_tree(struct fs_context *fc)
 
 	if (fc->fs_type->fs_flags & FS_REQUIRES_DEV && !fc->source) {
 		errorf(fc, "Filesystem requires source device");
-		return -ENOENT;
+		return -EINVAL;
 	}
 
 	if (fc->root)
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 4 lines · Murphy Zhou

From: Xiong Zhou <[email protected]>

mount(2) with a NULL source device would return ENOENT instead of EINVAL after this commit:

See ee948837d7fa in vfs.git#fixes...

#2 lore raw
Quoted 8 lines · Al Viro
Quoted 4 lines · Murphy Zhou

From: Xiong Zhou <[email protected]>

mount(2) with a NULL source device would return ENOENT instead of EINVAL after this commit:

See ee948837d7fa in vfs.git#fixes...

Got it. Thanks!