Skip to contentSkip to conversation

fpga manager: Adding FPGA Manager support for Xilinx zynqmp

bug report Dan Carpenter 1 participant 1 message May 2, 2019 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

Hello Nava kishore Manne,

The patch c09f7471127e: "fpga manager: Adding FPGA Manager support for Xilinx zynqmp" from Apr 15, 2019, leads to the following static checker warning:

drivers/fpga/zynqmp-fpga.c:50 zynqmp_fpga_ops_write()
error: 'eemi_ops' dereferencing possible ERR_PTR()

drivers/fpga/zynqmp-fpga.c

    40  static int zynqmp_fpga_ops_write(struct fpga_manager *mgr,
    41                                   const char *buf, size_t size)
    42  {
    43          const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
    44          struct zynqmp_fpga_priv *priv;
    45          dma_addr_t dma_addr;
    46          u32 eemi_flags = 0;
    47          char *kbuf;
    48          int ret;
    49  
    50          if (!eemi_ops || !eemi_ops->fpga_load)
                     ^^^^^^^^

This is an error pointer. Possibly you want to handle EPROBE_DEFER in a special way?

    51                  return -ENXIO;
    52  

See also:

drivers/fpga/zynqmp-fpga.c:84 zynqmp_fpga_ops_state() error: 'eemi_ops' dereferencing possible ERR_PTR()

regards,
dan carpenter