Skip to contentSkip to conversation

doc/distributor: add SST-BF enhancement info

PATCH Applied David Hunt 3 participants 7 messages May 2, 2019 – May 3, 2019

lore
Share & tools
lore

David Hunt

author
#0 lore raw

PATCH 1/3 doc/distributor: add SST-BF enhancement info

The distributor sample application has been enhanced to be aware of Intel SST-BF high frequency cores. Docs also contain a link to the Intel SST-BF application note.

---
 doc/guides/sample_app_ug/dist_app.rst | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
doc/guides/sample_app_ug/dist_app.rst +19 -1
index abfdd2c5e..90270e3a5 100644
@@ -5,7 +5,9 @@ Distributor Sample Application
 ==============================
 
 The distributor sample application is a simple example of packet distribution
-to cores using the Data Plane Development Kit (DPDK).
+to cores using the Data Plane Development Kit (DPDK). It also makes use of
+Intel Speed Select Technology - Base Frequency (Intel SST-BF) to pin the
+distributor to the higher frequency core if available.
 
 Overview
 --------
@@ -101,6 +103,22 @@ final statistics to the user.
    Distributor Sample Application Layout
 
 
+Intel SST-BF Support
+--------------------
+
+In DPDK 19.05, support was added to the power management library for
+Intel-SST-BF, a technology that allows some cores to run at a higher
+frequency than others. An application note for Intel SST-BF is available,
+and is entitled
+`Intel Speed Select Technology – Base Frequency - Enhancing Performance <https://builders.intel.com/docs/networkbuilders/intel-speed-select-technology-base-frequency-enhancing-performance.pdf>`_
+
+The distributor application was also enhanced to be aware of these higher
+frequency SST-BF cores, and when starting the application, if high frequency
+SST-BF cores are present in the core mask, the application will identify these
+cores and pin the workloads appropriately. The distributor core is usually
+the bottleneck, so this is given first choice of the high frequency SST-BF
+cores, followed by the rx core and the tx core.
+
 Debug Logging Support
 ---------------------
 
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/3 doc: add release note for power changes

In the Power Library, a new bit has been added to the mask returned by rte_power_get_capabilities which indicates whether the core is an Intel SST-BF high frequency core.

The Distributor sample app has also been enhanced to make use of SST-BF cores, and pin relevant workloads to the higher frequency cores, if available in the core mask provided to the application.

---
 doc/guides/rel_notes/release_19_05.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)
doc/guides/rel_notes/release_19_05.rst +11 -0
index d5ed564ab..b0b71dc7b 100644
@@ -187,6 +187,17 @@ New Features
   Improved testpmd application performance on ARM platform. For ``macswap``
   forwarding mode, NEON intrinsics were used to do swap to save CPU cycles.
 
+* **Updated power management library.**
+
+  Added support for Intel Speed Select Technology - Base Frequency (SST-BF).
+  ``rte_power_get_capabilities`` now has a bit in it's returned mask
+  indicating it's a high frequency core.
+
+* **Updated distributor sample application.**
+
+  Added support for Intel SST-BF feature so that the distributor core is
+  pinned to a high frequency core if available.
+
 
 Removed Items
 -------------
Signature · 1 line
2.17.1
author
#4 lore raw

PATCH 3/3 lib/power: clarify comment on priority core

In reply to David Hunt

As part of the documentation update on the changes made to the power library for 19.05, information on SST-BF was added. This patch updates the comment to clarify that a priority core is an SST-BF high frequency core.

---
 lib/librte_power/rte_power.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_power/rte_power.h +1 -1
index 0650112ad..01f88588b 100644
@@ -259,7 +259,7 @@ struct rte_power_core_capabilities {
 		RTE_STD_C11
 		struct {
 			uint64_t turbo:1;	/**< Turbo can be enabled. */
-			uint64_t priority:1;	/**< Priority core */
+			uint64_t priority:1;	/**< SST-BF high freq core */
 		};
 	};
 };
Signature · 1 line
2.17.1
Acked-by on v1 1/3
#6 lore raw
In reply to David Hunt
Quoted 10 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, May 2, 2019 12:18 PM
To: [email protected]
Cc: Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement info

Quoted 3 lines

The distributor sample application has been enhanced to be aware of Intel SST-BF high frequency cores. Docs also contain a link to the Intel SST-BF application note.

Acked-by on v1 2/3
#2 lore raw

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

In reply to David Hunt
Quoted 9 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, May 2, 2019 12:18 PM
To: [email protected]
Cc: Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

Quoted 8 lines

In the Power Library, a new bit has been added to the mask returned by rte_power_get_capabilities which indicates whether the core is an Intel SST-BF high frequency core.

The Distributor sample app has also been enhanced to make use of SST-BF cores, and pin relevant workloads to the higher frequency cores, if available in the core mask provided to the application.

Acked-by on v1 3/3
#5 lore raw

Re: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority core

In reply to David Hunt
Quoted 10 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, May 2, 2019 12:18 PM
To: [email protected]
Cc: Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority core

Quoted 3 lines

As part of the documentation update on the changes made to the power library for 19.05, information on SST-BF was added. This patch updates the comment to clarify that a priority core is an SST-BF high frequency core.

#3 lore raw

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

In reply to Mcnamara, John

02/05/2019 17:55, Mcnamara, John:

Quoted 10 lines

From: David Hunt

Quoted 7 lines

In the Power Library, a new bit has been added to the mask returned by rte_power_get_capabilities which indicates whether the core is an Intel SST-BF high frequency core.

The Distributor sample app has also been enhanced to make use of SST-BF cores, and pin relevant workloads to the higher frequency cores, if available in the core mask provided to the application.

Applied. Please try to update the release notes at the same time as the code. Thanks