Skip to contentSkip to conversation

mdadm: Disable Werror

PATCH New Khem Raj 1 participant 1 message May 3, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 mdadm: Disable Werror

Werror spews more warnings with gcc9, like other distros ( debian/fedora) disable Warnings as errors

Fixes

super-intel.c:696:9: error: taking address of packed member of 'struct imsm_super' may result in an unaligned pointer value [-Werror=address-of-packed-member]

---
 .../mdadm/files/debian-no-Werror.patch        | 25 +++++++++++++++++++
 meta/recipes-extended/mdadm/mdadm_4.1.bb      |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta/recipes-extended/mdadm/files/debian-no-Werror.patch
meta/recipes-extended/mdadm/files/debian-no-Werror.patch new file +25 -0
new file mode 100644
index 0000000000..e66a15cd79
@@ -0,0 +1,25 @@
+From: martin f. krafft <[email protected]>
+Subject: Remove -Werror from compiler flags
+
+-Werror seems like a bad idea on released/packaged code because a toolchain
+update (introducing new warnings) could break the build. We'll let upstream
+use it to beautify the code, but remove it for out builds.
+
+Signed-off-by: martin f. krafft <[email protected]>
+
+Upstream-Status: Pending
+---
+ Makefile |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+--- a/Makefile
++++ b/Makefile
+@@ -48,7 +48,7 @@ endif
+ 
+ CC ?= $(CROSS_COMPILE)gcc
+ CXFLAGS ?= -ggdb
+-CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter
++CWFLAGS = -Wall -Wstrict-prototypes -Wextra -Wno-unused-parameter
+ ifdef WARN_UNUSED
+ CWFLAGS += -Wp,-D_FORTIFY_SOURCE=2 -O3
+ endif
meta/recipes-extended/mdadm/mdadm_4.1.bb +1 -0
index 947706ff5f..ef5ddf55db 100644
@@ -17,6 +17,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/raid/mdadm/${BPN}-${PV}.tar.xz \
            file://0001-Use-CC-to-check-for-implicit-fallthrough-warning-sup.patch \
            file://0001-Compute-abs-diff-in-a-standard-compliant-way.patch \
            file://0001-fix-gcc-8-format-truncation-warning.patch \
+           file://debian-no-Werror.patch \
 	   file://mdadm.init \
 	   file://mdmonitor.service \
            "
Signature · 1 line
2.21.0