net/mlx5: potential error pointer dereference in error handling
Subsystems (3)
PATCH 1/1 net/mlx5: potential error pointer dereference in error handling
The error handling was a bit flipped around. If the mlx5_create_flow_group() function failed then it would have resulted in dereferencing "fg" when it was an error pointer.
Fixes 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/rdma.c +2 -2
@@ -106,10 +106,10 @@ static int mlx5_rdma_enable_roce_steering(struct mlx5_core_dev *dev)return 0 ; -destroy_flow_table: -mlx5_destroy_flow_table (ft); destroy_flow_group:mlx5_destroy_flow_group (fg); +destroy_flow_table: +mlx5_destroy_flow_table (ft); free:kvfree (spec);kvfree (flow_group_in);
Signature · 1 line
2.18.0
Quoted 9 lines · Dan Carpenter
The error handling was a bit flipped around. If the
mlx5_create_flow_group()function failed then it would have resulted in dereferencing "fg" when it was an error pointer.Fixes 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic")Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Sorry for the delay, applied to mlx5-next branch.6cc070bdf07c net/mlx5: potential error pointer dereference in error handling
Thanks