mt76: add mac80211 driver for MT7615 PCIe-based chipsets

Hello Ryder Lee,

This is a semi-automatic email about new static checker warnings.

The patch 04b8e65922f6: "mt76: add mac80211 driver for MT7615 PCIe-based chipsets" from Apr 1, 2019, leads to the following Smatch complaint:

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:1012 mt7615_mcu_set_wtbl_key()
error: we previously assumed 'key' could be null (see line 1008)

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
1007 cipher = mt7615_get_key_info(key, wtbl_sec_key.key_material);
1008 if (cipher == MT_CIPHER_NONE && key)

                                                        ^^^

This check doesn't make much sense. Do you want to just remove it?

  1009				return -EOPNOTSUPP;
  1010	
  1011			wtbl_sec_key.cipher_id = cipher;
  1012			wtbl_sec_key.key_id = key->keyidx;
                                              ^^^^^^^^^^^
  1013			wtbl_sec_key.key_len = key->keylen;
  1014		} else {

regards,
dan carpenter

Just in case that 'key != NULL' but 'cipher == MT_CIPHER_NONE'. It should not happen.