dmaengine: at_xdmac: remove a stray bottom half unlock

PATCH Applied Dan Carpenter 2 participants 2 messages May 3, 2019 – May 4, 2019

Subsystems (3)

Kernel janitors dmaengine Microchip AT91 DMA drivers

lore

Share & tools

lore

Dan Carpenter

author

2019-05-03 13:15 UTC #0 lore raw

PATCH 1/1 dmaengine: at_xdmac: remove a stray bottom half unlock

We switched this code from spin_lock_bh() to vanilla spin_lock() but there was one stray spin_unlock_bh() that was overlooked. This patch converts it to spin_unlock() as well.

Fixes d8570d018f69 ("dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/dma/at_xdmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/dma/at_xdmac.c +1 -1

index 06cbe54e4c30..e4ae2ee46d3f 100644
@@ -1655,7 +1655,7 @@ static void at_xdmac_tasklet(unsigned long data)
 		dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
 		if (!desc->active_xfer) {
 			dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting");
-			spin_unlock_bh(&atchan->lock);
+			spin_unlock(&atchan->lock);
 			return;
 		}

Signature · 1 line

2.18.0

Vinod Koul

maintainer Applied

2019-05-04 10:41 UTC #1 lore raw

Quoted 3 lines · Dan Carpenter

We switched this code from spin_lock_bh() to vanilla spin_lock() but there was one stray spin_unlock_bh() that was overlooked. This patch converts it to spin_unlock() as well.

Applied, thanks

Signature · 1 line

~Vinod