Skip to contentSkip to conversation

imx: Use a convenient default value for SYS_MALLOC_F_LEN

PATCH New Fabio Estevam 8 participants 9 messages May 3, 2019 – Jun 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

 Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Kconfig +2 -0
index 7a5491bd67..fd4ff42c17 100644
@@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
 	depends on SYS_MALLOC_F
 	default 0x1000 if AM33XX
 	default 0x2800 if SANDBOX
+	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
 	default 0x400
 	help
 	  Before relocation, memory is very limited on many platforms. Still,
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

Hi Fabio,

Le 03/05/2019 à 19:05, Fabio Estevam a écrit :

Quoted 30 lines

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

  Kconfig | 2 ++
  1 file changed, 2 insertions(+)
Kconfig +0 -0
index 7a5491bd67..fd4ff42c17 100644

Kconfig config SYS_MALLOC_F_LEN · line 145

Quoted 8 lines
Kconfig +2 -0
@@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
  	depends on SYS_MALLOC_F
  	default 0x1000 if AM33XX
  	default 0x2800 if SANDBOX
+	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
  	default 0x400
  	help
  	  Before relocation, memory is very limited on many platforms. Still,

Thanks

Pierre-Jean

#2 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

Hi Fabio,

Tested-by Joris Offouga <[email protected]>

BR,

Joris

Le ven. 3 mai 2019 à 19:20, Pierre-Jean Texier <[email protected]> a écrit :

Quoted 53 lines

Hi Fabio,

Quoted 9 lines · Fabio Estevam

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory

to

Quoted 21 lines

do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

  Kconfig | 2 ++
  1 file changed, 2 insertions(+)
Kconfig +0 -0
index 7a5491bd67..fd4ff42c17 100644

Kconfig config SYS_MALLOC_F_LEN · line 145

Quoted 8 lines
Kconfig +2 -0
@@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
      depends on SYS_MALLOC_F
      default 0x1000 if AM33XX
      default 0x2800 if SANDBOX
+     default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+                        ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
      default 0x400
      help
        Before relocation, memory is very limited on many platforms.

Still,

Thanks

Pierre-Jean

#3 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

In reply to Fabio Estevam

Hi Fabio

Tested-by Joris Offouga <[email protected] >

BR

Joris

Quoted 43 lines · Fabio Estevam

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

 Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Kconfig +2 -0
index 7a5491bd67..fd4ff42c17 100644
@@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
        depends on SYS_MALLOC_F
        default 0x1000 if AM33XX
        default 0x2800 if SANDBOX
+       default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+                          ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
        default 0x400
        help
          Before relocation, memory is very limited on many platforms.

Still,
--
2.17.1

#4 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Quoted 6 lines

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

Good work.

Tested: warp7_bl33, warp7

#5 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

In reply to Fabio Estevam
Quoted 17 lines · Fabio Estevam

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

Quoted 8 lines

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

 Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Thank you for sending the patch!

#6 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

In reply to Fabio Estevam
Quoted 42 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2019年5月4日 1:05
To: sbabic at denx.de
Cc: dl-uboot-imx <[email protected]>; u-boot at lists.denx.de; pjtexier at koncepto.io; lukas.auer at aisec.fraunhofer.de; offougajoris at gmail.com; trini at konsulko.com; Fabio Estevam <[email protected]>
Subject: [PATCH v2] imx: Use a convenient default value for SYS_MALLOC_F_LEN

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

 Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Kconfig +0 -0
index 7a5491bd67..fd4ff42c17 100644

Kconfig config SYS_MALLOC_F_LEN · line 145

Quoted 8 lines
Kconfig +2 -0
@@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
 	depends on SYS_MALLOC_F
 	default 0x1000 if AM33XX
 	default 0x2800 if SANDBOX
+	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
 	default 0x400
 	help
 	  Before relocation, memory is very limited on many platforms. Still,
Quoted 2 lines

--
2.17.1

#7 lore raw

PATCH v2 1/1 imx: Use a convenient default value for SYS_MALLOC_F_LEN

In reply to Fabio Estevam

Hello Fabio,

Am 03.05.2019 um 19:05 schrieb Fabio Estevam:

Quoted 17 lines

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."

Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

Quoted 7 lines

---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend on i.MX

  Kconfig | 2 ++
  1 file changed, 2 insertions(+)

Thanks for this fix! This solves my issue with patch [PATCH] simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver

on a not yet mainlined imx6ull based board.

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#8 lore raw

PATCH v2 1/1 imx: Use a convenient default value for

In reply to Fabio Estevam
Quoted 10 lines

Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver") causes some i.MX boards that were converted to DM, such as warp7, to fail to boot.
As explained by Lukas Auer:
"With the patch, U-Boot probes the drivers for devices under simple-bus device tree nodes in the pre-relocation device model. The default value of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to do this, causing it to hang."
Fix this problem by providing a convenient default value for CONFIG_SYS_MALLOC_F_LEN.

Quoted 8 lines

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================