Skip to contentSkip to conversation

tests/docker: Update the Fedora image to Fedora 30

PATCH Superseded Philippe Mathieu-Daudé 4 participants 6 messages May 4, 2019 – May 29, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/docker: Update the Fedora image to Fedora 30

Fedora 30 got released:

https://fedoramagazine.org/announcing-fedora-30/

---
Based-on: <[email protected]>
qxl: fix -Waddress-of-packed-member

Based-on: <[email protected]>

          Pull request trivial branch 2019-05-03
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/fedora.docker +1 -1
index 69d4a7f5d75..1496b68ba15 100644
@@ -1,4 +1,4 @@
-FROM fedora:29
+FROM fedora:30
 ENV PACKAGES \
     bc \
     bison \
Signature · 1 line
2.20.1
#1 lore raw
Quoted 11 lines · Philippe Mathieu-Daudé

Fedora 30 got released:

https://fedoramagazine.org/announcing-fedora-30/

---
Based-on: <[email protected]>
qxl: fix -Waddress-of-packed-member

Based-on: <[email protected]>

          Pull request trivial branch 2019-05-03

'based-on' series got merged, ping?

Quoted 15 lines
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/fedora.docker +1 -1
index 69d4a7f5d75..1496b68ba15 100644
@@ -1,4 +1,4 @@
-FROM fedora:29
+FROM fedora:30
 ENV PACKAGES \
     bc \
     bison \
Tested-by Reviewed-by
#2 lore raw
Quoted 10 lines · Philippe Mathieu-Daudé
Quoted 9 lines · Philippe Mathieu-Daudé

Fedora 30 got released:

https://fedoramagazine.org/announcing-fedora-30/

---
Based-on: <[email protected]>
qxl: fix -Waddress-of-packed-member

Quoted 5 lines
Quoted 2 lines

Based-on: <[email protected]>

          Pull request trivial branch 2019-05-03

'based-on' series got merged, ping?

Tested running 'make docker-test-build@fedora'

Thanks,
Stefano

#3 lore raw
In reply to Philippe Mathieu-Daudé
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base"

# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===

inlined from ‘fill_psinfo’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3208:12,
inlined from ‘fill_note_info’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3390:5,
inlined from ‘elf_core_dump’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3539:9:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Werror=stringop-truncation]

  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

The full log is available at
http://patchew.org/logs/[email protected]/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

#4 lore raw

Hi Patchew,

Quoted 7 lines · On 5/24/19 3:28 PM, [email protected] wrote:

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series failed build test on s390x host. Please find the details below.

"20 days later", not yet a movie title.

Quoted 7 lines

inlined from ‘fill_psinfo’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3208:12,
inlined from ‘fill_note_info’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3390:5,
inlined from ‘elf_core_dump’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3539:9:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Werror=stringop-truncation]

  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

This has been fixed by the following commit, merged earlier today:

commit d7eb2b928a855a2e8038e8e75f7edf1a12226bd3

Author: Alistair Francis <[email protected]>
Date:   Tue Apr 30 23:29:01 2019 +0000

linux-user/elfload: Fix GCC 9 build warnings

Fix this warning when building with GCC9 on Fedora 30:
In function ‘strncpy’,
inlined from ‘fill_psinfo’ at
/home/alistair/qemu/linux-user/elfload.c:3208:12,
inlined from ‘fill_note_info’ at
/home/alistair/qemu/linux-user/elfload.c:3390:5,
inlined from ‘elf_core_dump’ at
/home/alistair/qemu/linux-user/elfload.c:3539:9:

    /usr/include/bits/string_fortified.h:106:10: error:
‘__builtin_strncpy’ specified bound 16 equals destination size
[-Werror=stringop-truncation]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len,
__bos (__dest));
          |

^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Quoted 3 lines

---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

Done!

#5 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 5 lines · Philippe Mathieu-Daudé

Fedora 30 got released:

https://fedoramagazine.org/announcing-fedora-30/

Queued to testing/next, thanks.

Quoted 15 lines

---
Based-on: <[email protected]>
qxl: fix -Waddress-of-packed-member

Based-on: <[email protected]>

          Pull request trivial branch 2019-05-03
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/fedora.docker +0 -0
index 69d4a7f5d75..1496b68ba15 100644

tests/docker/dockerfiles/fedora.docker line 4

Quoted 5 lines
tests/docker/dockerfiles/fedora.docker +1 -1
@@ -1,4 +1,4 @@
-FROM fedora:29
+FROM fedora:30
 ENV PACKAGES \
     bc \
     bison \

--
Alex Bennée