ALSA: synth: emux: soundfont.c: divide by zero in calc_gus_envelope_time()
Subsystems (2)
PATCH 1/1 ALSA: synth: emux: soundfont.c: divide by zero in calc_gus_envelope_time()
This function is called from load_guspatch() and the rate is specified by the user. If they accidentally selected zero then it would crash the kernel. I've just changed the zero to a one.
Signed-off-by Dan Carpenter <[email protected]>
--- sound/synth/emux/soundfont.c | 2 ++ 1 file changed, 2 insertions(+)
sound/synth/emux/soundfont.c +2 -0
@@ -856,6 +856,8 @@ calc_gus_envelope_time(int rate, int start, int end)int r, p, t; r = (3 - ((rate >>6 ) &3 )) *3 ; p = rate &0x3f ; +if (!p) + p =1 ; t = end - start;if (t <0 ) t = -t;if (13 > r)
Signature · 1 line
2.18.0
Takashi Iwai
AppliedQuoted 6 lines · Dan Carpenter
This function is called from
load_guspatch()and the rate is specified by the user. If they accidentally selected zero then it would crash the kernel. I've just changed the zero to a one.Signed-off-by Dan Carpenter <[email protected]>
Thanks, applied now.
Takashi
Quoted 21 lines
--- sound/synth/emux/soundfont.c | 2 ++ 1 file changed, 2 insertions(+)sound/synth/emux/soundfont.c +2
-0@@ -856,6 +856,8 @@ calc_gus_envelope_time(int rate, int start, int end)int r, p, t; r = (3 - ((rate >>6 ) &3 )) *3 ; p = rate &0x3f ; +if (!p) + p =1 ; t = end - start;if (t <0 ) t = -t;if (13 > r)Signature · 1 line
2.18.0