btrfs: Return EAGAIN if we can't start no snpashot write in check_can_nocow
PATCH 1/1 btrfs: Return EAGAIN if we can't start no snpashot write in check_can_nocow
The first thing code does in check_can_nocow is trying to block concurrent snapshots. If this fails (due to snpashot already being in progress) the function returns ENOSPC which makes no sense. Instead return EAGAIN. Despite this return value not being propagated to callers it's good practice to return the closest in terms of semantics error code. No functional changes.
--- fs/btrfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/file.c +1 -1
@@ -1556,7 +1556,7 @@ static noinline int check_can_nocow(struct btrfs_inode *inode, loff_t pos, ret =btrfs_start_write_no_snapshotting (root);if (!ret) -return -ENOSPC ; +return -EAGAIN ; lockstart =round_down (pos, fs_info->sectorsize); lockend = round_up(pos + *write_bytes,
Signature · 1 line
2.17.1
Quoted 8 lines · Nikolay Borisov
The first thing code does in
check_can_nocowis trying to block concurrent snapshots. If this fails (due to snpashot already being in progress) the function returns ENOSPC which makes no sense. Instead return EAGAIN. Despite this return value not being propagated to callers it's good practice to return the closest in terms of semantics error code. No functional changes.Signed-off-by Nikolay Borisov <[email protected]>
Added to 5.3 queue, thanks.