Skip to contentSkip to conversation

cogl: remove -Werror=maybe-uninitialized workaround

PATCH New Adrian Bunk 1 participant 1 message May 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cogl: remove -Werror=maybe-uninitialized workaround

This should now also be covered by the
DEBUG_OPTIMIZATION_append = " -Wno-error=maybe-uninitialized"

---
 ...lling.c-fix-may-be-used-uninitialize.patch | 35 -------------------
 meta/recipes-graphics/cogl/cogl-1.0_1.22.4.bb |  2 --
 2 files changed, 37 deletions(-)
 delete mode 100644 meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch
meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch deleted +0 -35
deleted file mode 100644
index 479a0ff4b5..0000000000
@@ -1,35 +0,0 @@
-From a51f61d675a0e7d6649182c6a1325ceab8342df2 Mon Sep 17 00:00:00 2001
-From: Robert Yang <[email protected]>
-Date: Mon, 4 Jan 2016 22:47:29 -0800
-Subject: [PATCH] test-backface-culling.c: fix may be used uninitialized error
-
-Fixed when gcc -O:
-test-backface-culling.c:206:7: error: 'cull_front' may be used uninitialized in this function [-Werror=maybe-uninitialized]
-|        validate_part (framebuffer,
-|        ^
-| cc1: some warnings being treated as errors
-
-Upstream-Status: Pending
-
-Signed-off-by: Robert Yang <[email protected]>
----
- tests/conform/test-backface-culling.c |    3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
-
-diff --git a/tests/conform/test-backface-culling.c b/tests/conform/test-backface-culling.c
-index e90c2f5..7c45592 100644
---- a/tests/conform/test-backface-culling.c
-+++ b/tests/conform/test-backface-culling.c
-@@ -164,7 +164,8 @@ validate_result (CoglFramebuffer *framebuffer, int y_offset)
- 
-   for (draw_num = 0; draw_num < 16; draw_num++)
-     {
--      CoglBool cull_front, cull_back;
-+      CoglBool cull_front = FALSE;
-+      CoglBool cull_back = FALSE;
-       CoglPipelineCullFaceMode cull_mode;
- 
-       if (USE_LEGACY_STATE (draw_num))
--- 
-1.7.9.5
-
meta/recipes-graphics/cogl/cogl-1.0_1.22.4.bb +0 -2
index 432025233b..8e61c19f5d 100644
@@ -1,7 +1,5 @@
 require cogl-1.0.inc
 
-SRC_URI += "file://test-backface-culling.c-fix-may-be-used-uninitialize.patch \
-"
 SRC_URI[archive.md5sum] = "31755015a865c4af51ac84f6e53af8ab"
 SRC_URI[archive.sha256sum] = "5217bf94cbca3df63268a3b79d017725382b9e592b891d1e7dc6212590ce0de0"
 
Signature · 1 line
2.17.1