Skip to contentSkip to conversation

libxl: don't enable synthetic timer by default

PATCH In review Wei Liu 3 participants 3 messages May 7, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 libxl: don't enable synthetic timer by default

It broke Windows installation. More investigation is needed. Don't enable it by default.

---
Cc: Ian Jackson <[email protected]>
Cc: Paul Durrant <[email protected]>
Cc: Juergen Gross <[email protected]>

---
 tools/libxl/libxl_dom.c | 1 -
 1 file changed, 1 deletion(-)
tools/libxl/libxl_dom.c +0 -1
index 879c806139..c5685b061c 100644
@@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
-        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
     }
 
     libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Wei Liu [mailto:[email protected]]
Sent: 07 May 2019 14:36
To: [email protected]
Cc: Wei Liu <[email protected]>; Ian Jackson <[email protected]>; Paul Durrant <[email protected]>; Juergen Gross <[email protected]>
Subject: [PATCH] libxl: don't enable synthetic timer by default

Quoted 4 lines

It broke Windows installation. More investigation is needed. Don't enable it by default.

Quoted 21 lines

---
Cc: Ian Jackson <[email protected]>
Cc: Paul Durrant <[email protected]>
Cc: Juergen Gross <[email protected]>

---
 tools/libxl/libxl_dom.c | 1 -
 1 file changed, 1 deletion(-)
tools/libxl/libxl_dom.c +0 -2
index 879c806139..c5685b061c 100644
@@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
-        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
     }
 
     libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
--
Quoted 1 line

2.20.1

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel