Skip to contentSkip to conversation

x86/events/amd/iommu: Make symbol 'amd_iommu_attr_groups' static

PATCH New Wang Hai 2 participants 2 messages May 8, 2019

Subsystems (2)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 x86/events/amd/iommu: Make symbol 'amd_iommu_attr_groups' static

Fix the following sparse warning:

arch/x86/events/amd/iommu.c:396:30: warning:
symbol 'amd_iommu_attr_groups' was not declared. Should it be static?

Fixes 51686546304f (x86/events/amd/iommu: Fix sysfs perf attribute groups)
---
 arch/x86/events/amd/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/amd/iommu.c +1 -1
index 7635c23f7d82..58a6993d7eb3 100644
@@ -393,7 +393,7 @@ static __init int _init_events_attrs(void)
 	return 0;
 }
 
-const struct attribute_group *amd_iommu_attr_groups[] = {
+static const struct attribute_group *amd_iommu_attr_groups[] = {
 	&amd_iommu_format_group,
 	&amd_iommu_cpumask_group,
 	&amd_iommu_events_group,
Signature · 1 line
2.17.1
#1 lore raw

[tip:perf/urgent] perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static

perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static
Commit-ID:  4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8
Gitweb:     https://git.kernel.org/tip/4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8
Author:     Wang Hai <[email protected]>
AuthorDate: Wed, 8 May 2019 10:04:18 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 8 May 2019 13:35:32 +0200

perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static

Fixes the following sparse warning:

arch/x86/events/amd/iommu.c:396:30: warning:
symbol 'amd_iommu_attr_groups' was not declared. Should it be static?

Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Fixes 51686546304f (x86/events/amd/iommu: Fix sysfs perf attribute groups)
---
 arch/x86/events/amd/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/amd/iommu.c +1 -1
index 7635c23f7d82..58a6993d7eb3 100644
@@ -393,7 +393,7 @@ static __init int _init_events_attrs(void)
 	return 0;
 }
 
-const struct attribute_group *amd_iommu_attr_groups[] = {
+static const struct attribute_group *amd_iommu_attr_groups[] = {
 	&amd_iommu_format_group,
 	&amd_iommu_cpumask_group,
 	&amd_iommu_events_group,