ASoC: max98357a: request GPIO when device get probed
PATCH 1/1 ASoC: max98357a: request GPIO when device get probed
devm_gpiod_get_optional() returns EBUSY after component rebound.
Request GPIO in max98357a_platform_probe() to support component rebinding.
Signed-off-by Tzung-Bi Shih <[email protected]>
---
v1:
ASoC: max98357a: manage GPIO for component rebinding => don't move from devm to non-devm
v2:
ASoC: max98357a: release GPIO when component removing
=> only put things that really need the card in component's probe() => don't use devm_gpiod_put() if possible
sound/soc/codecs/max98357a.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
sound/soc/codecs/max98357a.c +9 -8
@@ -61,14 +61,6 @@ static const struct snd_soc_dapm_route max98357a_dapm_routes[] = {static int max98357a_component_probe (struct snd_soc_component *component) { -struct gpio_desc *sdmode; - - sdmode =devm_gpiod_get_optional (component->dev,"sdmode" ,GPIOD_OUT_LOW ); -if (IS_ERR (sdmode)) -return PTR_ERR (sdmode); - -snd_soc_component_set_drvdata (component, sdmode); -return 0 ; }
@@ -112,6 +104,15 @@ static struct snd_soc_dai_driver max98357a_dai_driver = {static int max98357a_platform_probe (struct platform_device *pdev) { +struct gpio_desc *sdmode; + + sdmode =devm_gpiod_get_optional (&pdev->dev, +"sdmode" ,GPIOD_OUT_LOW ); +if (IS_ERR (sdmode)) +return PTR_ERR (sdmode); + +dev_set_drvdata (&pdev->dev, sdmode); +return devm_snd_soc_register_component (&pdev->dev, &max98357a_component_driver, &max98357a_dai_driver,1 );
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
Mark Brown
maintainersound/soc/codecs/max98357a.c static const struct snd_soc_dapm_route max98357a_dapm_routes[] = { · line 65
Quoted 13 lines · Tzung-Bi Shih
static int
max98357a_component_probe(struct snd_soc_component *component){sound/soc/codecs/max98357a.c +0
-8-struct gpio_desc *sdmode; - - sdmode =devm_gpiod_get_optional (component->dev,"sdmode" ,GPIOD_OUT_LOW ); -if (IS_ERR (sdmode)) -return PTR_ERR (sdmode); - -snd_soc_component_set_drvdata (component, sdmode); -return 0 ; }
This function is now empty so can just be removed entirely. Otherwise this looks good.