Skip to contentSkip to conversation

btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails

PATCH In review Qu Wenruo 3 participants 3 messages May 9, 2019 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails

At the context of btrfs_run_delalloc_range(), we haven't started/joined a transaction, thus even something went wrong, we can't and won't abort transaction, thus no way to make the fs RO.

---
 fs/btrfs/extent_io.c | 1 -
 1 file changed, 1 deletion(-)
fs/btrfs/extent_io.c +0 -1
index 13fca7bfc1f2..85023bb322f0 100644
@@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
 		}
 		ret = btrfs_run_delalloc_range(inode, page, delalloc_start,
 				delalloc_end, &page_started, nr_written, wbc);
-		/* File system has been set read-only */
 		if (ret) {
 			SetPageError(page);
 			/*
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Qu Wenruo

At the context of btrfs_run_delalloc_range(), we haven't started/joined a transaction, thus even something went wrong, we can't and won't abort transaction, thus no way to make the fs RO.

Quoted 17 lines
---
 fs/btrfs/extent_io.c | 1 -
 1 file changed, 1 deletion(-)
fs/btrfs/extent_io.c +0 -1
index 13fca7bfc1f2..85023bb322f0 100644
@@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
 		}
 		ret = btrfs_run_delalloc_range(inode, page, delalloc_start,
 				delalloc_end, &page_started, nr_written, wbc);
-		/* File system has been set read-only */
 		if (ret) {
 			SetPageError(page);
 			/*