virtio-input-host-pci: cleanup types
PATCH 1/2 virtio-input-host-pci: cleanup types
virtio input is virtio-1.0 only, so we don't need the -transitional and -non-transitional variants.
Signed-off-by Gerd Hoffmann <[email protected]>
--- hw/virtio/virtio-input-host-pci.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
hw/virtio/virtio-input-host-pci.c +2 -6
@@ -13,7 +13,7 @@typedef struct VirtIOInputHostPCI VirtIOInputHostPCI ; -#define TYPE_VIRTIO_INPUT_HOST_PCI "virtio-input-host-pci-base" +#define TYPE_VIRTIO_INPUT_HOST_PCI "virtio-input-host-pci"#define VIRTIO_INPUT_HOST_PCI (obj) \ OBJECT_CHECK(VirtIOInputHostPCI, (obj), TYPE_VIRTIO_INPUT_HOST_PCI)
@@ -31,11 +31,7 @@ static void virtio_host_initfn(Object *obj) }static const VirtioPCIDeviceTypeInfo virtio_input_host_pci_info = { - .base_name =TYPE_VIRTIO_INPUT_HOST_PCI , - .generic_name ="virtio-input-host-pci" , - .transitional_name ="virtio-input-host-pci-transitional" , - .non_transitional_name ="virtio-input-host-pci-non-transitional" , - .parent =TYPE_VIRTIO_INPUT_PCI , + .generic_name =TYPE_VIRTIO_INPUT_HOST_PCI , .instance_size =sizeof (VirtIOInputHostPCI), .instance_init = virtio_host_initfn, };
Signature · 1 line
2.18.1
PATCH 2/2 virtio-input: fix Kconfig dependency and Makefile
Make VIRTIO_INPUT_HOST depend on VIRTIO_INPUT.
Use CONFIG_VIRTIO_INPUT_HOST in Makefile.
Signed-off-by Gerd Hoffmann <[email protected]>
--- hw/input/Kconfig | 2 +- hw/input/Makefile.objs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)
hw/input/Kconfig +1 -1
@@ -27,7 +27,7 @@ config VIRTIO_INPUT config VIRTIO_INPUT_HOST bool default y - depends on VIRTIO && LINUX + depends on VIRTIO_INPUT && LINUX config VHOST_USER_INPUT bool
hw/input/Makefile.objs +1 -3
@@ -9,9 +9,7 @@ common-obj-$(CONFIG_TSC2005) += tsc2005.o common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input.o common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-hid.o -ifeq ($(CONFIG_LINUX),y) -common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-host.o -endif +common-obj-$(CONFIG_VIRTIO_INPUT_HOST) += virtio-input-host.o common-obj-$(CONFIG_VHOST_USER_INPUT) += vhost-user-input.o obj-$(CONFIG_MILKYMIST) += milkymist-softusb.o
Signature · 1 line
2.18.1
Re: [Qemu-devel] [PATCH 2/2] virtio-input: fix Kconfig dependency and Makefile
Quoted 5 lines · Gerd Hoffmann
Make
VIRTIO_INPUT_HOSTdepend onVIRTIO_INPUT.
UseCONFIG_VIRTIO_INPUT_HOSTinMakefile.Signed-off-by Gerd Hoffmann <[email protected]>
Reviewed-by Marc-André Lureau <[email protected]>
Quoted 37 lines
--- hw/input/Kconfig | 2 +- hw/input/Makefile.objs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)hw/input/Kconfig +1
-1@@ -27,7 +27,7 @@ config VIRTIO_INPUT config VIRTIO_INPUT_HOST bool default y - depends on VIRTIO && LINUX + depends on VIRTIO_INPUT && LINUX config VHOST_USER_INPUT boolhw/input/Makefile.objs +1
-4@@ -9,9 +9,7 @@ common-obj-$(CONFIG_TSC2005) += tsc2005.o common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input.o common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-hid.o -ifeq ($(CONFIG_LINUX),y) -common-obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-host.o -endif +common-obj-$(CONFIG_VIRTIO_INPUT_HOST) += virtio-input-host.o common-obj-$(CONFIG_VHOST_USER_INPUT) += vhost-user-input.o obj-$(CONFIG_MILKYMIST) += milkymist-softusb.o --2.18.1
Signature · 1 line
Marc-André Lureau
Hi
Quoted 23 lines · Gerd Hoffmann
virtio input is virtio-1.0 only, so we don't need the -transitional and -non-transitional variants.
Signed-off-by Gerd Hoffmann <[email protected]>--- hw/virtio/virtio-input-host-pci.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)hw/virtio/virtio-input-host-pci.c +1
-1@@ -13,7 +13,7 @@typedef struct VirtIOInputHostPCI VirtIOInputHostPCI ; -#define TYPE_VIRTIO_INPUT_HOST_PCI "virtio-input-host-pci-base" +#define TYPE_VIRTIO_INPUT_HOST_PCI "virtio-input-host-pci"#define VIRTIO_INPUT_HOST_PCI (obj) \ OBJECT_CHECK(VirtIOInputHostPCI, (obj), TYPE_VIRTIO_INPUT_HOST_PCI)
hw/virtio/virtio-input-host-pci.c static void virtio_host_initfn(Object *obj) · line 38
Quoted 8 lines
hw/virtio/virtio-input-host-pci.c +0
-5@@ -31,11 +31,7 @@ static void virtio_host_initfn(Object *obj) }static const VirtioPCIDeviceTypeInfo virtio_input_host_pci_info = { - .base_name =TYPE_VIRTIO_INPUT_HOST_PCI , - .generic_name ="virtio-input-host-pci" , - .transitional_name ="virtio-input-host-pci-transitional" , - .non_transitional_name ="virtio-input-host-pci-non-transitional" , - .parent =TYPE_VIRTIO_INPUT_PCI ,
nack, without the parent field it doesn't work
Quoted 8 lines
hw/virtio/virtio-input-host-pci.c +1
-1+ .generic_name = TYPE_VIRTIO_INPUT_HOST_PCI, .instance_size = sizeof(VirtIOInputHostPCI), .instance_init = virtio_host_initfn, }; --2.18.1
Signature · 1 line
Marc-André Lureau