Recent changes (master)
The following changes since commit f22dd97a5a1342c7dcb84f777a77bd30859cc35b:
Update CFLAGS and LDFLAGS for FreeBSD builds (2019-05-06 22:18:55 -0600)
are available in the Git repository at:
git://git.kernel.dk/fio.git master
for you to fetch changes up to 2857c34bd39fcd67c489a8e2b19d9455032bad0f:
t/io_uring: clarify polled support is fs + device (2019-05-08 11:56:05 -0600)
----------------------------------------------------------------
Jens Axboe (1):
t/io_uring: clarify polled support is fs + device
t/io_uring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
---
Diff of recent changes:
t/io_uring.c +2 -1
@@ -264,7 +264,8 @@ static int reap_events(struct submitter *s)if (cqe->res !=BS ) {printf ("io: unexpected ret=%d\n" , cqe->res);if (polled && cqe->res == -EOPNOTSUPP ) -printf ("Your filesystem doesn't support poll\n" ); +printf ("Your filesystem/device doesn't " +"support polled IO\n" );return -1 ; } }
Isn't that also related to the kernel version you use ?
This message might mislead the user as he might just have to upgrade his kernel to gain the feature ?
Le 09/05/2019 à 14:00, Jens Axboe a écrit :
Quoted 37 lines
The following changes since commit
f22dd97a5a1342c7dcb84f777a77bd30859cc35b:Update CFLAGS and LDFLAGS for FreeBSD builds (2019-05-06 22:18:55 -0600)
are available in the Git repository at:
git://git.kernel.dk/fio.gitmasterfor you to fetch changes up to
2857c34bd39fcd67c489a8e2b19d9455032bad0f:t/io_uring: clarify polled support is fs + device (2019-05-08 11:56:05 -0600)----------------------------------------------------------------
Jens Axboe (1):
t/io_uring: clarify polled support is fs + devicet/io_uring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)---
Diff of recent changes:
t/io_uring.c +2
-1@@ -264,7 +264,8 @@ static int reap_events(struct submitter *s)if (cqe->res !=BS ) {printf ("io: unexpected ret=%d\n" , cqe->res);if (polled && cqe->res == -EOPNOTSUPP ) -printf ("Your filesystem doesn't support poll\n" ); +printf ("Your filesystem/device doesn't " +"support polled IO\n" );return -1 ; } }
Quoted 4 lines · Erwan Velu
Isn't that also related to the kernel version you use ?
This message might mislead the user as he might just have to upgrade his kernel to gain the feature ?
Yes, the message is for the specific kernel, it doesn't speak for any future kernels. But I think we're getting into documentation at this point, the message just means that on this setup, either the fs or device driver (or both) doesn't support polled IO.
Signature · 1 line
Jens Axboe
Quoted 8 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Jens Axboe
Sent: Thursday, May 09, 2019 7:00 AM
To: [email protected]
Subject: Recent changes (master)
...
t/io_uring.c static int reap_events(struct submitter *s) · line 268
Quoted 5 lines
(quoted diff) +0
-1- printf("Your filesystem doesn'tsupport poll\n");
(quoted diff) +1
-0+ printf("Your filesystem/devicedoesn't "
t/io_uring.c +1
-0+ "support polled IO\n");
Can you keep that string on one line so it is grep-able?
Quoted 8 lines · Robert (Servers)
Quoted 8 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Jens Axboe
Sent: Thursday, May 09, 2019 7:00 AM
To: [email protected]
Subject: Recent changes (master)
Quoted 10 lines
...
t/io_uring.c static int reap_events(struct submitter *s) · line 268
Quoted 5 lines
(quoted diff) +0
-1- printf("Your filesystem doesn'tsupport poll\n");
(quoted diff) +1
-0+ printf("Your filesystem/devicedoesn't "
t/io_uring.c +1
-0+ "support polled IO\n");Can you keep that string on one line so it is grep-able?
This
+ printf("Your filesystem/device doesn't "
+ "support polled IO\n");
will print one line in standard output:
Your filesystem/device doesn't support polled IO
Do you mean that you want to grep in the source code ?
Quoted 8 lines · Robert (Servers)
Quoted 8 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Jens Axboe
Sent: Thursday, May 09, 2019 7:00 AM
To: [email protected]
Subject: Recent changes (master)
Quoted 8 lines
...
t/io_uring.c static int reap_events(struct submitter *s) · line 268
Quoted 5 lines
(quoted diff) +0
-1- printf("Your filesystem doesn'tsupport poll\n");
(quoted diff) +1
-0+ printf("Your filesystem/devicedoesn't "
t/io_uring.c +1
-0+ "support polled IO\n");Can you keep that string on one line so it is grep-able?
To keep everyone happy, I changed it to one line AND added a kernel mention too.
Next up, color of the build ;-)
Signature · 1 line
Jens Axboe
Quoted 9 lines
This
(quoted diff) +1
-0+ printf("Your filesystem/devicedoesn't "
t/io_uring.c +1
-0+ "support polled IO\n");
Quoted 6 lines
will print one line in standard output:
Your filesystem/device doesn't support polled IO
Do you mean that you want to grep in the source code ?
Yes, like Linus Torvalds complained about years ago:
"I've had grep's that fail due to people splitting the actual string etc, which just drives me wild."
https://lkml.org/lkml/2009/12/17/229
It's part of the linux kernel coding style (which fio doesn't strictly follow, but generally does):
"Statements longer than 80 columns will be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."