Skip to contentSkip to conversation

vmcore: Add a kernel cmdline device_dump_limit

RFC PATCH Superseded Kairui Song 3 participants 7 messages May 10, 2019 – May 20, 2019

Subsystems (4)

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 vmcore: Add a kernel cmdline device_dump_limit

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

---
 fs/proc/vmcore.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
fs/proc/vmcore.c +20 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
 /* Device Dump list and mutex to synchronize access to list */
 static LIST_HEAD(vmcoredd_list);
 static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
 	data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
 			    PAGE_SIZE);
 
+	if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+		ret = -ENOMEM;
+		goto out_err;
+	}
+
 	/* Allocate buffer for driver's to write their dumps */
 	buf = vmcore_alloc_buf(data_size);
 	if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
 	return ret;
 }
 EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+	char *end;
+
+	if (!arg)
+		return -EINVAL;
+	vmcoredd_limit = memparse(arg, &end);
+	return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Free all dumps in vmcore device dump list */
Signature · 7 lines
2.20.1


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#1 lore raw

Hi Kairui,

Thanks for the patch. Please see my comments in-line:

Quoted 10 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam

^^^^ acceptable maximum

Quoted 3 lines

memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

Hmmm., this doesn't give much confidence with the PROC_VMCORE_DEVICE_DUMP feature in its current shape. Rather shouldn't we be enabling config PROC_VMCORE_DEVICE_DUMP only under EXPERT mode for now, considering that this feature needs further thrashing and testing with real setups including platforms where drivers append large amounts of data to vmcore:

fs/proc/Kconfig +7 -1
index 817c02b13b1d..c47a12cf7fc0 100644
@@ -45,7 +45,7 @@ config PROC_VMCORE
         Exports the dump image of crashed kernel in ELF format.
 
 config PROC_VMCORE_DEVICE_DUMP
-       bool "Device Hardware/Firmware Log Collection"
+       bool "Device Hardware/Firmware Log Collection" if EXPERT
        depends on PROC_VMCORE
        default n
        help
@@ -59,6 +59,12 @@ config PROC_VMCORE_DEVICE_DUMP
          If you say Y here, the collected device dumps will be added
          as ELF notes to /proc/vmcore.
 
+         Considering that there can be device drivers which append
+         large amounts of data to vmcore, you should say N here unless
+         you are reserving a large chunk of memory for crashdump
+         kernel, because otherwise the crashdump kernel might become
+         unusable due to OOM issues.
+
 

May be you can add a 'Fixes:' tag here.

Quoted 20 lines
---
  fs/proc/vmcore.c | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)
fs/proc/vmcore.c +3 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
  /* Device Dump list and mutex to synchronize access to list */
  static LIST_HEAD(vmcoredd_list);
  static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
  #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
  /* Device Dump Size */

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1472

Quoted 5 lines
fs/proc/vmcore.c +2 -0
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
  	data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
  			    PAGE_SIZE);
 
+	if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+		ret = -ENOMEM;

Should we be adding a WARN() here to let the user know that the device dump data will not be available in vmcore?

Quoted 12 lines
fs/proc/vmcore.c +5 -0
+		goto out_err;
+	}
+
  	/* Allocate buffer for driver's to write their dumps */
  	buf = vmcore_alloc_buf(data_size);
  	if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
  	return ret;
  }
  EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1524

Quoted 10 lines
fs/proc/vmcore.c +10 -0
+{
+	char *end;
+
+	if (!arg)
+		return -EINVAL;
+	vmcoredd_limit = memparse(arg, &end);
+	return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);

We should be adding this boot argument and its description to 'Documentation/admin-guide/kernel-parameters.txt'

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1527

Quoted 4 lines
fs/proc/vmcore.c +0 -0
  #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
  /* Free all dumps in vmcore device dump list */

Thanks,
Bhupesh

#2 lore raw
Quoted 13 lines · Bhupesh Sharma

Hi Kairui,

Thanks for the patch. Please see my comments in-line:

Quoted 7 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

Quoted 5 lines
Quoted 3 lines

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam

^^^^ acceptable maximum

Will fix this typo.

Quoted 11 lines
Quoted 4 lines

memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

Hmmm., this doesn't give much confidence with the PROC_VMCORE_DEVICE_DUMP feature in its current shape. Rather shouldn't we be enabling config PROC_VMCORE_DEVICE_DUMP only under EXPERT mode for now, considering that this feature needs further thrashing and testing with real setups including platforms where drivers append large amounts of data to vmcore:

I think no need to move it to expert mode, just leave it disabled by default should be better, that should be enough to make sure driver won't append that much memory and cause OOM, while it could still be enabled without changing the kernel, so this feature won't bring extra risk, and could be enabled anytime easily.

Quoted 25 lines
fs/proc/Kconfig +7 -1
index 817c02b13b1d..c47a12cf7fc0 100644
@@ -45,7 +45,7 @@ config PROC_VMCORE
          Exports the dump image of crashed kernel in ELF format.
 
  config PROC_VMCORE_DEVICE_DUMP
-       bool "Device Hardware/Firmware Log Collection"
+       bool "Device Hardware/Firmware Log Collection" if EXPERT
         depends on PROC_VMCORE
         default n
         help
@@ -59,6 +59,12 @@ config PROC_VMCORE_DEVICE_DUMP
           If you say Y here, the collected device dumps will be added
           as ELF notes to /proc/vmcore.
 
+         Considering that there can be device drivers which append
+         large amounts of data to vmcore, you should say N here unless
+         you are reserving a large chunk of memory for crashdump
+         kernel, because otherwise the crashdump kernel might become
+         unusable due to OOM issues.
+
 
Quoted 1 line

May be you can add a 'Fixes:' tag here.

Problem is previous commit seems not broken, just bring extra memory stress. Is "Fixes:" tag suitable for this commit?

Quoted 24 lines
Quoted 24 lines
---
  fs/proc/vmcore.c | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)
fs/proc/vmcore.c +3 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
  /* Device Dump list and mutex to synchronize access to list */
  static LIST_HEAD(vmcoredd_list);
  static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
  #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
  /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
      data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
                          PAGE_SIZE);
 
Quoted 5 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1472

Quoted 2 lines
fs/proc/vmcore.c +2 -0
+     if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+             ret = -ENOMEM;

Should we be adding a WARN() here to let the user know that the device dump data will not be available in vmcore?

Yes, that could be very helpful. How about pr_err_once? WARN is too noise, just give a hint to the user that device dump is disabled should be enough, so user will know why device dump data is not present and will just enable it.

Quoted 18 lines
Quoted 18 lines
fs/proc/vmcore.c +10 -0
+             goto out_err;
+     }
+
      /* Allocate buffer for driver's to write their dumps */
      buf = vmcore_alloc_buf(data_size);
      if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
      return ret;
  }
  EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+     char *end;
+
+     if (!arg)
+             return -EINVAL;
Quoted 8 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1524

Quoted 5 lines
fs/proc/vmcore.c +5 -0
+     vmcoredd_limit = memparse(arg, &end);
+     return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);

We should be adding this boot argument and its description to 'Documentation/admin-guide/kernel-parameters.txt'

Good suggestion, will update the document.

Quoted 8 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1527

Quoted 5 lines
fs/proc/vmcore.c +0 -0
  #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
  /* Free all dumps in vmcore device dump list */

Thanks,
Bhupesh

Thanks for the review!

--
Best Regards,
Kairui Song

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw
Quoted 14 lines · Kairui Song
Quoted 13 lines · Bhupesh Sharma

Hi Kairui,

Thanks for the patch. Please see my comments in-line:

Quoted 7 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam

^^^^ acceptable maximum

Will fix this typo.

Ok.

Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

Hmmm., this doesn't give much confidence with the PROC_VMCORE_DEVICE_DUMP feature in its current shape. Rather shouldn't we be enabling config PROC_VMCORE_DEVICE_DUMP only under EXPERT mode for now, considering that this feature needs further thrashing and testing with real setups including platforms where drivers append large amounts of data to vmcore:

Quoted 5 lines

I think no need to move it to expert mode, just leave it disabled by default should be better, that should be enough to make sure driver won't append that much memory and cause OOM, while it could still be enabled without changing the kernel, so this feature won't bring extra risk, and could be enabled anytime easily.

I have seen some arm64 users report issues on mailing lists with PROC_VMCORE_DEVICE_DUMP enabled as this causes frequent OOM in the arm64 crash dump kernel.

I think they are using this infrastructure to extend/enable device driver debugging on some arm64 platforms and finding issues with the crash dump kernel.

I will do some analysis later-on (when I get some spare time) and post a patch (if needed) to put the same under EXPERT mode for now.

Quoted 24 lines
Quoted 24 lines
fs/proc/Kconfig +7 -1
index 817c02b13b1d..c47a12cf7fc0 100644
@@ -45,7 +45,7 @@ config PROC_VMCORE
           Exports the dump image of crashed kernel in ELF format.
 
   config PROC_VMCORE_DEVICE_DUMP
-       bool "Device Hardware/Firmware Log Collection"
+       bool "Device Hardware/Firmware Log Collection" if EXPERT
          depends on PROC_VMCORE
          default n
          help
@@ -59,6 +59,12 @@ config PROC_VMCORE_DEVICE_DUMP
            If you say Y here, the collected device dumps will be added
            as ELF notes to /proc/vmcore.
 
+         Considering that there can be device drivers which append
+         large amounts of data to vmcore, you should say N here unless
+         you are reserving a large chunk of memory for crashdump
+         kernel, because otherwise the crashdump kernel might become
+         unusable due to OOM issues.
+
 
Quoted 4 lines
Quoted 1 line

May be you can add a 'Fixes:' tag here.

Problem is previous commit seems not broken, just bring extra memory stress. Is "Fixes:" tag suitable for this commit?

I think since the earlier patch causes an OOM, it would be better to atleast mention it in the git log (for easier git bisect later on).

If not the 'Fixes:' tag may be we can use a 'Since commit ..' like wording in the commit log.

Quoted 29 lines
Quoted 23 lines
Quoted 23 lines
---
   fs/proc/vmcore.c | 20 ++++++++++++++++++++
   1 file changed, 20 insertions(+)
fs/proc/vmcore.c +3 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
   /* Device Dump list and mutex to synchronize access to list */
   static LIST_HEAD(vmcoredd_list);
   static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
   #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
   /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
       data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
                           PAGE_SIZE);
 
Quoted 5 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1472

Quoted 2 lines
fs/proc/vmcore.c +2 -0
+     if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+             ret = -ENOMEM;

Should we be adding a WARN() here to let the user know that the device dump data will not be available in vmcore?

Quoted 4 lines

Yes, that could be very helpful. How about pr_err_once? WARN is too noise, just give a hint to the user that device dump is disabled should be enough, so user will know why device dump data is not present and will just enable it.

Sure, pr_err() should be OK as well.

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
fs/proc/vmcore.c +10 -0
+             goto out_err;
+     }
+
       /* Allocate buffer for driver's to write their dumps */
       buf = vmcore_alloc_buf(data_size);
       if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
       return ret;
   }
   EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+     char *end;
+
+     if (!arg)
+             return -EINVAL;
Quoted 8 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1524

Quoted 5 lines
fs/proc/vmcore.c +5 -0
+     vmcoredd_limit = memparse(arg, &end);
+     return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);

We should be adding this boot argument and its description to 'Documentation/admin-guide/kernel-parameters.txt'

Quoted 7 lines

Good suggestion, will update the document.

Quoted 5 lines
Quoted 5 lines
fs/proc/vmcore.c +0 -0
   #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
   /* Free all dumps in vmcore device dump list */

Thanks,
Bhupesh

#4 lore raw
Quoted 154 lines · Bhupesh Sharma
Quoted 14 lines · Kairui Song
Quoted 13 lines · Bhupesh Sharma

Hi Kairui,

Thanks for the patch. Please see my comments in-line:

Quoted 7 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam

^^^^ acceptable maximum

Will fix this typo.

Ok.

Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

Hmmm., this doesn't give much confidence with the PROC_VMCORE_DEVICE_DUMP feature in its current shape. Rather shouldn't we be enabling config PROC_VMCORE_DEVICE_DUMP only under EXPERT mode for now, considering that this feature needs further thrashing and testing with real setups including platforms where drivers append large amounts of data to vmcore:

Quoted 5 lines

I think no need to move it to expert mode, just leave it disabled by default should be better, that should be enough to make sure driver won't append that much memory and cause OOM, while it could still be enabled without changing the kernel, so this feature won't bring extra risk, and could be enabled anytime easily.

I have seen some arm64 users report issues on mailing lists with PROC_VMCORE_DEVICE_DUMP enabled as this causes frequent OOM in the arm64 crash dump kernel.

I think they are using this infrastructure to extend/enable device driver debugging on some arm64 platforms and finding issues with the crash dump kernel.

I will do some analysis later-on (when I get some spare time) and post a patch (if needed) to put the same under EXPERT mode for now.

Quoted 24 lines
Quoted 24 lines
fs/proc/Kconfig +7 -1
index 817c02b13b1d..c47a12cf7fc0 100644
@@ -45,7 +45,7 @@ config PROC_VMCORE
           Exports the dump image of crashed kernel in ELF format.
 
   config PROC_VMCORE_DEVICE_DUMP
-       bool "Device Hardware/Firmware Log Collection"
+       bool "Device Hardware/Firmware Log Collection" if EXPERT
          depends on PROC_VMCORE
          default n
          help
@@ -59,6 +59,12 @@ config PROC_VMCORE_DEVICE_DUMP
            If you say Y here, the collected device dumps will be added
            as ELF notes to /proc/vmcore.
 
+         Considering that there can be device drivers which append
+         large amounts of data to vmcore, you should say N here unless
+         you are reserving a large chunk of memory for crashdump
+         kernel, because otherwise the crashdump kernel might become
+         unusable due to OOM issues.
+
 
Quoted 4 lines
Quoted 1 line

May be you can add a 'Fixes:' tag here.

Problem is previous commit seems not broken, just bring extra memory stress. Is "Fixes:" tag suitable for this commit?

I think since the earlier patch causes an OOM, it would be better to atleast mention it in the git log (for easier git bisect later on).

If not the 'Fixes:' tag may be we can use a 'Since commit ..' like wording in the commit log.

Quoted 29 lines
Quoted 23 lines
Quoted 23 lines
---
   fs/proc/vmcore.c | 20 ++++++++++++++++++++
   1 file changed, 20 insertions(+)
fs/proc/vmcore.c +3 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
   /* Device Dump list and mutex to synchronize access to list */
   static LIST_HEAD(vmcoredd_list);
   static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
   #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
   /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
       data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
                           PAGE_SIZE);
 
Quoted 5 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1472

Quoted 2 lines
fs/proc/vmcore.c +2 -0
+     if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+             ret = -ENOMEM;

Should we be adding a WARN() here to let the user know that the device dump data will not be available in vmcore?

Quoted 4 lines

Yes, that could be very helpful. How about pr_err_once? WARN is too noise, just give a hint to the user that device dump is disabled should be enough, so user will know why device dump data is not present and will just enable it.

Sure, pr_err() should be OK as well.

Quoted 29 lines
Quoted 17 lines
Quoted 17 lines
fs/proc/vmcore.c +10 -0
+             goto out_err;
+     }
+
       /* Allocate buffer for driver's to write their dumps */
       buf = vmcore_alloc_buf(data_size);
       if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
       return ret;
   }
   EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+     char *end;
+
+     if (!arg)
+             return -EINVAL;
Quoted 8 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1524

Quoted 5 lines
fs/proc/vmcore.c +5 -0
+     vmcoredd_limit = memparse(arg, &end);
+     return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);

We should be adding this boot argument and its description to 'Documentation/admin-guide/kernel-parameters.txt'

Good suggestion, will update the document.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

fs/proc/vmcore.c int vmcore_add_device_dump(struct vmcoredd_data *data) · line 1527

Quoted 4 lines
fs/proc/vmcore.c +0 -0
   #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
   /* Free all dumps in vmcore device dump list */

Thanks,
Bhupesh

Thanks for the reply, I've updated the patch accordingly and sent V2.

Signature · 7 lines
Best Regards,
Kairui Song

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#5 lore raw
In reply to Kairui Song
Quoted 7 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

Quoted 5 lines

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

The device dump is only affective in kdump 2nd kernel, so add the limitation seems not useful. One is hard to know the correct size unless one does some crash test. If one did the test and want to eanble the device dump he needs increase crashkernel= size in 1st kernel and add the limit param in 2nd kernel.

So a global on/off param sounds easier and better, something like vmcore_device_dump=on (default is off)

Quoted 54 lines
---
 fs/proc/vmcore.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
fs/proc/vmcore.c +20 -0
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
 /* Device Dump list and mutex to synchronize access to list */
 static LIST_HEAD(vmcoredd_list);
 static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
 	data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
 			    PAGE_SIZE);
 
+	if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+		ret = -ENOMEM;
+		goto out_err;
+	}
+
 	/* Allocate buffer for driver's to write their dumps */
 	buf = vmcore_alloc_buf(data_size);
 	if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
 	return ret;
 }
 EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+	char *end;
+
+	if (!arg)
+		return -EINVAL;
+	vmcoredd_limit = memparse(arg, &end);
+	return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Free all dumps in vmcore device dump list */
Signature · 1 line
2.20.1

Thanks
Dave

#6 lore raw
Quoted 15 lines · Dave Young
Quoted 7 lines · Kairui Song

Device dump allow drivers to add device related dump data to vmcore as they want. This have a potential issue, the data is stored in memory, drivers may append too much data and use too much memory. The vmcore is typically used in a kdump kernel which runs in a pre-reserved small chunk of memory. So as a result it will make kdump unusable at all due to OOM issues.

Quoted 5 lines

So introduce new device_dump_limit= kernel parameter, and set the default limit to 0, so device dump is not enabled unless user specify the accetable maxiam memory usage for device dump data. In this way user will also have the chance to adjust the kdump reserved memory accordingly.

Quoted 8 lines

The device dump is only affective in kdump 2nd kernel, so add the limitation seems not useful. One is hard to know the correct size unless one does some crash test. If one did the test and want to eanble the device dump he needs increase crashkernel= size in 1st kernel and add the limit param in 2nd kernel.

So a global on/off param sounds easier and better, something like vmcore_device_dump=on (default is off)

Yes, on/off could be another way to solve this issue, the size limit could being more flexibility, if device dump is not asking for too much memory then it would just work but bring extra complexity indeed. Considering it's actually hard to know how much memory is needed for the device dump drivers to work, I'll update to use the on/off cmdline then.

Quoted 58 lines
Quoted 53 lines
---
 fs/proc/vmcore.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
fs/proc/vmcore.c +20 -1
index 3fe90443c1bb..e28695ef2439 100644
@@ -53,6 +53,9 @@ static struct proc_dir_entry *proc_vmcore;
 /* Device Dump list and mutex to synchronize access to list */
 static LIST_HEAD(vmcoredd_list);
 static DEFINE_MUTEX(vmcoredd_mutex);
+
+/* Device Dump Limit */
+static size_t vmcoredd_limit;
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Device Dump Size */
@@ -1465,6 +1468,11 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
      data_size = roundup(sizeof(struct vmcoredd_header) + data->size,
                          PAGE_SIZE);
 
+     if (vmcoredd_orig_sz + data_size >= vmcoredd_limit) {
+             ret = -ENOMEM;
+             goto out_err;
+     }
+
      /* Allocate buffer for driver's to write their dumps */
      buf = vmcore_alloc_buf(data_size);
      if (!buf) {
@@ -1502,6 +1510,18 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
      return ret;
 }
 EXPORT_SYMBOL(vmcore_add_device_dump);
+
+static int __init parse_vmcoredd_limit(char *arg)
+{
+     char *end;
+
+     if (!arg)
+             return -EINVAL;
+     vmcoredd_limit = memparse(arg, &end);
+     return end > arg ? 0 : -EINVAL;
+
+}
+__setup("device_dump_limit=", parse_vmcoredd_limit);
 #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */
 
 /* Free all dumps in vmcore device dump list */
--
Quoted 2 lines

2.20.1

Thanks
Dave

Signature · 2 lines
Best Regards,
Kairui Song