Skip to contentSkip to conversation

dt-bindings: gpio: Convert Arm PL061 to json-schema

PATCH In review Rob Herring 3 participants 5 messages May 14, 2019 – Jun 12, 2019

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: gpio: Convert Arm PL061 to json-schema

Convert the Arm PL061 GPIO controller binding to json-schema format.

As I'm the author for all but the gpio-ranges line, make the schema dual GPL/BSD license.

Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>

---
This warns on a few platforms missing clocks, interrupt-controller and/or #interrupt-cells. We could not make those required, but really they should be IMO. OTOH, it's platforms like Spear and Calxeda which aren't too active, so I don't know that we want to fix them.

 .../devicetree/bindings/gpio/pl061-gpio.txt   | 10 ---
 .../devicetree/bindings/gpio/pl061-gpio.yaml  | 69 +++++++++++++++++++
 2 files changed, 69 insertions(+), 10 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpio/pl061-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
Documentation/devicetree/bindings/gpio/pl061-gpio.txt deleted +0 -10
deleted file mode 100644
index 89058d375b7c..000000000000
@@ -1,10 +0,0 @@
-ARM PL061 GPIO controller
-
-Required properties:
-- compatible : "arm,pl061", "arm,primecell"
-- #gpio-cells : Should be two. The first cell is the pin number and the
-  second cell is used to specify optional parameters:
-  - bit 0 specifies polarity (0 for normal, 1 for inverted)
-- gpio-controller : Marks the device node as a GPIO controller.
-- interrupts : Interrupt mapping for GPIO IRQ.
-- gpio-ranges : Interaction with the PINCTRL subsystem.
Documentation/devicetree/bindings/gpio/pl061-gpio.yaml new file +69 -0

69 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw
Quoted 9 lines · Rob Herring

Convert the Arm PL061 GPIO controller binding to json-schema format.

As I'm the author for all but the gpio-ranges line, make the schema dual GPL/BSD license.

Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>

Patch applied. As you know I am already a big fan of this scheme.

Quoted 4 lines

This warns on a few platforms missing clocks, interrupt-controller and/or #interrupt-cells. We could not make those required, but really they should be IMO. OTOH, it's platforms like Spear and Calxeda which aren't too active, so I don't know that we want to fix them.

What works for you works for me.

We could add dummy fixed clocks in the DTS files if
we wanted I suppose. The #interrupt-cells and interrupt-controller things we can just fix, but I wonder what the maintainers of these platforms are up to? Isn't Calxeda yours, and could Viresh fix up the SPEAr?

Yours,
Linus Walleij

#2 lore raw
Quoted 19 lines · Linus Walleij
Quoted 9 lines · Rob Herring

Convert the Arm PL061 GPIO controller binding to json-schema format.

As I'm the author for all but the gpio-ranges line, make the schema dual GPL/BSD license.

Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>

Patch applied. As you know I am already a big fan of this scheme.

Quoted 4 lines

This warns on a few platforms missing clocks, interrupt-controller and/or #interrupt-cells. We could not make those required, but really they should be IMO. OTOH, it's platforms like Spear and Calxeda which aren't too active, so I don't know that we want to fix them.

Quoted 7 lines

What works for you works for me.

We could add dummy fixed clocks in the DTS files if
we wanted I suppose. The #interrupt-cells and interrupt-controller things we can just fix, but I wonder what the maintainers of these platforms are up to? Isn't Calxeda yours, and could Viresh fix up the SPEAr?

I checked SPEAr and it is missing interrupt-controller at few places and clocks everywhere. Missing clocks should be fine as SPEAr doesn't get clocks from DT.

And interrupt-controller can be just added, I don't think there would be any platform dependent side-affects ?

Signature · 1 line
viresh
author maintainer
#3 lore raw
Quoted 21 lines · Viresh Kumar
Quoted 19 lines · Linus Walleij
Quoted 9 lines · Rob Herring

Convert the Arm PL061 GPIO controller binding to json-schema format.

As I'm the author for all but the gpio-ranges line, make the schema dual GPL/BSD license.

Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>

Patch applied. As you know I am already a big fan of this scheme.

Quoted 4 lines

This warns on a few platforms missing clocks, interrupt-controller and/or #interrupt-cells. We could not make those required, but really they should be IMO. OTOH, it's platforms like Spear and Calxeda which aren't too active, so I don't know that we want to fix them.

Quoted 7 lines
Quoted 7 lines

What works for you works for me.

We could add dummy fixed clocks in the DTS files if
we wanted I suppose. The #interrupt-cells and interrupt-controller things we can just fix, but I wonder what the maintainers of these platforms are up to? Isn't Calxeda yours, and could Viresh fix up the SPEAr?

I was hoping to delete Calxeda rather than fix. I'm pretty sure none of the distros are using the systems anymore and they were the main users for a while. Otherwise, I would have converted all the bindings it uses.

Quoted 2 lines

I checked SPEAr and it is missing interrupt-controller at few places and clocks everywhere. Missing clocks should be fine as SPEAr doesn't get clocks from DT.

Clocks not from DT was supposed to be a transitional thing...

Quoted 3 lines

And interrupt-controller can be just added, I don't think there would be any platform dependent side-affects ?

There shouldn't be.

Rob

#4 lore raw
Quoted 5 lines · Rob Herring
Quoted 2 lines · Viresh Kumar

I checked SPEAr and it is missing interrupt-controller at few places and clocks everywhere. Missing clocks should be fine as SPEAr doesn't get clocks from DT.

Clocks not from DT was supposed to be a transitional thing...

Right, but by the time I left ST in 2012, mainline clock's DT support wasn't there and the SPEAr core team got fired soon after that. No one was left in ST to do the porting, but there are still people using the SPEAr boards and there are products in market, so we can't delete the platform as well.

So, no one is going to add clock DT support now.

Quoted 4 lines
Quoted 2 lines

And interrupt-controller can be just added, I don't think there would be any platform dependent side-affects ?

There shouldn't be.

Okay, will send a patch for that then.

Signature · 1 line
viresh