staging: wilc1000: Fix some double unlock bugs in wilc_wlan_cleanup()
Subsystems (2)
PATCH 1/1 staging: wilc1000: Fix some double unlock bugs in wilc_wlan_cleanup()
If ->hif_read_reg() or ->hif_write_reg() fail then the code unlocks and keeps executing. It should just return.
Fixes c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/staging/wilc1000/wilc_wlan.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/staging/wilc1000/wilc_wlan.c +6 -2
@@ -1076,13 +1076,17 @@ void wilc_wlan_cleanup(struct net_device *dev)acquire_bus (wilc,WILC_BUS_ACQUIRE_AND_WAKEUP ); ret = wilc->hif_func->hif_read_reg (wilc,WILC_GP_REG_0 , ®); -if (!ret) +if (!ret) {release_bus (wilc,WILC_BUS_RELEASE_ALLOW_SLEEP ); +return ; + } ret = wilc->hif_func->hif_write_reg (wilc,WILC_GP_REG_0 , (reg |ABORT_INT )); -if (!ret) +if (!ret) {release_bus (wilc,WILC_BUS_RELEASE_ALLOW_SLEEP ); +return ; + }release_bus (wilc,WILC_BUS_RELEASE_ALLOW_SLEEP ); wilc->hif_func->hif_deinit (NULL );
Signature · 1 line
2.20.1