Skip to contentSkip to conversation

mmc: tegra: Fix a warning message

PATCH New Dan Carpenter 1 participant 1 message May 15, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mmc: tegra: Fix a warning message

The WARN_ON() macro takes a condition, not a warning message. Really, this should probably be dev_warn_once().

Fixes ea8fc5953e8b ("mmc: tegra: update hw tuning process")

---
v2: Use dev_warn_once()

 drivers/mmc/host/sdhci-tegra.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +2 -1
index f608417ae967..fc07970acaf5 100644
@@ -865,7 +865,8 @@ static void tegra_sdhci_tap_correction(struct sdhci_host *host, u8 thd_up,
 	}
 
 	if (!first_fail) {
-		WARN_ON("no edge detected, continue with hw tuned delay.\n");
+		dev_warn_once(mmc_dev(host->mmc),
+			      "no edge detected, continue with hw tuned delay.\n");
 	} else if (first_pass) {
 		/* set tap location at fixed tap relative to the first edge */
 		edge1 = first_fail_tap + (first_pass_tap - first_fail_tap) / 2;
Signature · 1 line
2.20.1