char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
PATCH 3/3 char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
From: Naveen Kumar Parna <[email protected]>
According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its function/variable.
This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
--- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/char/misc.c +1 -2
@@ -226,6 +226,7 @@ int misc_register(struct miscdevice *misc)mutex_unlock (&misc_mtx);return err; } +EXPORT_SYMBOL (misc_register);/** * misc_deregister - unregister a miscellaneous device
@@ -249,8 +250,6 @@ void misc_deregister(struct miscdevice *misc)clear_bit (i, misc_minors);mutex_unlock (&misc_mtx); } - -EXPORT_SYMBOL (misc_register);EXPORT_SYMBOL (misc_deregister);static char *misc_devnode (struct device *dev,umode_t *mode)
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 5 lines · On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
From: Naveen Kumar Parna <[email protected]>
According to checkpatch:
EXPORT_SYMBOL(foo); should immediately follow its function/variable.
Quoted 7 lines
This patch fixes the following checkpatch.pl issues in
drivers/char/misc.c:
WARNING:EXPORT_SYMBOL(foo); should immediately follow its function/variableSigned-off-by Naveen Kumar Parna <[email protected]>--- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Where are patches 1/3 and 2/3 of this series?
Quoted 10 lines · Greg KH
Quoted 8 lines · On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
From: Naveen Kumar Parna <[email protected]>
According to checkpatch:
EXPORT_SYMBOL(foo); should immediately follow its function/variable.This patch fixes the following checkpatch.pl issues in
drivers/char/misc.c:
WARNING:EXPORT_SYMBOL(foo); should immediately follow its function/variable
Quoted 6 lines
Quoted 4 lines
Signed-off-by Naveen Kumar Parna <[email protected]>--- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)Where are patches 1/3 and 2/3 of this series?
It does not has corresponding 1/3 and 2/3 patches. By mistake I used wrong argument to 'git format-patch' command.
Quoted 1 line
Greg KH
maintainerQuoted 11 lines · Naveen Kumar Parna
Quoted 10 lines · Greg KH
Quoted 8 lines · On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
From: Naveen Kumar Parna <[email protected]>
According to checkpatch:
EXPORT_SYMBOL(foo); should immediately follow its function/variable.This patch fixes the following checkpatch.pl issues in
drivers/char/misc.c:
WARNING:EXPORT_SYMBOL(foo); should immediately follow its function/variable
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Naveen Kumar Parna <[email protected]>--- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)Where are patches 1/3 and 2/3 of this series?
It does not has corresponding 1/3 and 2/3 patches. By mistake I used wrong argument to 'git format-patch' command.
Ok, now dropped, please fix up and resend properly.
greg k-h