Skip to contentSkip to conversation

dax: Fix last_page check in __bdev_dax_supported()

PATCH In review Vaibhav Jain 2 participants 4 messages May 16, 2019 – May 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dax: Fix last_page check in __bdev_dax_supported()

Presently __bdev_dax_supported() checks if first sector of last page ( last_page ) on the block device is aligned to page boundary. However the code to compute 'last_page' assumes that there are 8 sectors/page assuming a 4K page-size.

This assumption breaks on architectures which use a different page size specifically PPC64 where page-size == 64K. Hence a warning is seen while trying to mount a xfs/ext4 file-system with dax enabled:

$ sudo mount -o dax /dev/pmem0 /mnt/pmem
XFS (pmem0): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
XFS (pmem0): DAX unsupported by block device. Turning off DAX.

The patch fixes this issue by updating calculation of 'last_var' to take into account number-of-sectors/page instead of assuming it to be '8'.

Fixes ad428cdb525a ("dax: Check the end of the block-device capacity with dax_direct_access()")
---
 drivers/dax/super.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/dax/super.c +3 -1
index bbd57ca0634a..6b50ed3673d3 100644
@@ -116,7 +116,9 @@ bool __bdev_dax_supported(struct block_device *bdev, int blocksize)
 		return false;
 	}
 
-	last_page = PFN_DOWN(i_size_read(bdev->bd_inode) - 1) * 8;
+	/* Calculate the first sector of last page on the block device */
+	last_page = PFN_DOWN(i_size_read(bdev->bd_inode) - 1) *
+		(PAGE_SIZE >> SECTOR_SHIFT);
 	err = bdev_dax_pgoff(bdev, last_page, PAGE_SIZE, &pgoff_end);
 	if (err) {
 		pr_debug("%s: error: unaligned partition for dax\n",
Signature · 6 lines
2.21.0

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
#1 lore raw
Quoted 10 lines · Vaibhav Jain

Presently __bdev_dax_supported() checks if first sector of last page ( last_page ) on the block device is aligned to page boundary. However the code to compute 'last_page' assumes that there are 8 sectors/page assuming a 4K page-size.

This assumption breaks on architectures which use a different page size specifically PPC64 where page-size == 64K. Hence a warning is seen while trying to mount a xfs/ext4 file-system with dax enabled:

Quoted 7 lines
$ sudo mount -o dax /dev/pmem0 /mnt/pmem
XFS (pmem0): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
XFS (pmem0): DAX unsupported by block device. Turning off DAX.

The patch fixes this issue by updating calculation of 'last_var' to take into account number-of-sectors/page instead of assuming it to be '8'.

Yes, I noticed this too and fixed it up in a wider change that also allows device-mapper to validate each component device. Does this patch work for you?

https://lore.kernel.org/lkml/155789172402.748145.11853718580748830476.stgit@dwillia2-desk3.amr.corp.intel.com/
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

#2 lore raw
Quoted 19 lines · Dan Williams
Quoted 10 lines · Vaibhav Jain

Presently __bdev_dax_supported() checks if first sector of last page ( last_page ) on the block device is aligned to page boundary. However the code to compute 'last_page' assumes that there are 8 sectors/page assuming a 4K page-size.

This assumption breaks on architectures which use a different page size specifically PPC64 where page-size == 64K. Hence a warning is seen while trying to mount a xfs/ext4 file-system with dax enabled:

Quoted 7 lines
$ sudo mount -o dax /dev/pmem0 /mnt/pmem
XFS (pmem0): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
XFS (pmem0): DAX unsupported by block device. Turning off DAX.

The patch fixes this issue by updating calculation of 'last_var' to take into account number-of-sectors/page instead of assuming it to be '8'.

Quoted 5 lines

Yes, I noticed this too and fixed it up in a wider change that also allows device-mapper to validate each component device. Does this patch work for you?

https://lore.kernel.org/lkml/155789172402.748145.11853718580748830476.stgit@dwillia2-desk3.amr.corp.intel.com/

Thanks Dan, I tested your patch and not seeing the issue anymore.

So, please ignore this patch.

Signature · 2 lines
Vaibhav Jain <[email protected]>
Linux Technology Center, IBM India Pvt. Ltd.
#3 lore raw
Quoted 22 lines · Vaibhav Jain
Quoted 19 lines · Dan Williams
Quoted 17 lines · Vaibhav Jain

Presently __bdev_dax_supported() checks if first sector of last page ( last_page ) on the block device is aligned to page boundary. However the code to compute 'last_page' assumes that there are 8 sectors/page assuming a 4K page-size.

This assumption breaks on architectures which use a different page size specifically PPC64 where page-size == 64K. Hence a warning is seen while trying to mount a xfs/ext4 file-system with dax enabled:

$ sudo mount -o dax /dev/pmem0 /mnt/pmem
XFS (pmem0): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
XFS (pmem0): DAX unsupported by block device. Turning off DAX.

The patch fixes this issue by updating calculation of 'last_var' to take into account number-of-sectors/page instead of assuming it to be '8'.

Quoted 7 lines
Quoted 5 lines

Yes, I noticed this too and fixed it up in a wider change that also allows device-mapper to validate each component device. Does this patch work for you?

https://lore.kernel.org/lkml/155789172402.748145.11853718580748830476.stgit@dwillia2-desk3.amr.corp.intel.com/

Thanks Dan, I tested your patch and not seeing the issue anymore.

Thanks, I recorded a "Tested-by" for you.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm