Skip to contentSkip to conversation

tcmode-default.inc: use the same TUNE_PKGARCH variable as PN set in go-cross

RFC PATCH New Martin Jansa 1 participant 1 message May 16, 2019

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 tcmode-default.inc: use the same TUNE_PKGARCH variable as PN set in go-cross

* otherwise P_V might be set for i686 and PN and RECIPE_MAINTAINER for i586 from bitbake -e lib32-gcc-cross-i686:

PREFERRED_VERSION_lib32-go-cross-i686="1.12%" RECIPE_MAINTAINER_pn-go-cross-i586="Khem Raj <[email protected]>"

  $ git grep 'go-cross-${'
  meta/conf/distro/include/maintainers.inc:RECIPE_MAINTAINER_pn-go-cross-${TUNE_PKGARCH} = "Khem Raj <[email protected]>"
  meta/conf/distro/include/tcmode-default.inc:PREFERRED_VERSION_go-cross-${TARGET_ARCH} ?= "${GOVERSION}"
  meta/recipes-devtools/go/go-cross.inc:PN = "go-cross-${TUNE_PKGARCH}"

* actually is there a reson to use TUNE_PKGARCH here (unlike other cross/canadian-cross recipes which are using TARGET_ARCH/TRANSLATED_TARGET_ARCH)?

---
 meta/conf/distro/include/tcmode-default.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/distro/include/tcmode-default.inc +1 -1
index daacfe28c4..668f31324e 100644
@@ -68,7 +68,7 @@ PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
 PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
 
 PREFERRED_VERSION_virtual/${TARGET_PREFIX}go ?= "${GOVERSION}"
-PREFERRED_VERSION_go-cross-${TARGET_ARCH} ?= "${GOVERSION}"
+PREFERRED_VERSION_go-cross-${TUNE_PKGARCH} ?= "${GOVERSION}"
 PREFERRED_VERSION_go-crosssdk-${SDK_ARCH} ?= "${GOVERSION}"
 PREFERRED_VERSION_go-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${GOVERSION}"
 PREFERRED_VERSION_go ?= "${GOVERSION}"
Signature · 1 line
2.17.1