net: caif: fix the value of size argument of snprintf
Subsystems (2)
PATCH 1/1 net: caif: fix the value of size argument of snprintf
From: swkhack <[email protected]>
Because the function snprintf write at most size bytes(including the null byte).So the value of the argument size need not to minus one.
Signed-off-by swkhack <[email protected]>
--- net/caif/cfdbgl.c | 2 +- net/caif/cfdgml.c | 3 +-- net/caif/cfutill.c | 2 +- net/caif/cfveil.c | 2 +- net/caif/cfvidl.c | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-)
net/caif/cfdbgl.c +1 -1
@@ -26,7 +26,7 @@ struct cflayer *cfdbgl_create(u8 channel_id, struct dev_info *dev_info)cfsrvl_init (dbg, channel_id, dev_info, false); dbg->layer.receive = cfdbgl_receive; dbg->layer.transmit = cfdbgl_transmit; -snprintf (dbg->layer.name,CAIF_LAYER_NAME_SZ -1 ,"dbg%d" , channel_id); +snprintf (dbg->layer.name,CAIF_LAYER_NAME_SZ ,"dbg%d" , channel_id);return &dbg->layer; }
net/caif/cfdgml.c +1 -2
@@ -33,8 +33,7 @@ struct cflayer *cfdgml_create(u8 channel_id, struct dev_info *dev_info)cfsrvl_init (dgm, channel_id, dev_info, true); dgm->layer.receive = cfdgml_receive; dgm->layer.transmit = cfdgml_transmit; -snprintf (dgm->layer.name,CAIF_LAYER_NAME_SZ -1 ,"dgm%d" , channel_id); - dgm->layer.name[CAIF_LAYER_NAME_SZ -1 ] ='\0' ; +snprintf (dgm->layer.name,CAIF_LAYER_NAME_SZ ,"dgm%d" , channel_id);return &dgm->layer; }
net/caif/cfutill.c +1 -1
@@ -33,7 +33,7 @@ struct cflayer *cfutill_create(u8 channel_id, struct dev_info *dev_info)cfsrvl_init (util, channel_id, dev_info, true); util->layer.receive = cfutill_receive; util->layer.transmit = cfutill_transmit; -snprintf (util->layer.name,CAIF_LAYER_NAME_SZ -1 ,"util1" ); +snprintf (util->layer.name,CAIF_LAYER_NAME_SZ ,"util1" );return &util->layer; }
net/caif/cfveil.c +1 -1
@@ -32,7 +32,7 @@ struct cflayer *cfvei_create(u8 channel_id, struct dev_info *dev_info)cfsrvl_init (vei, channel_id, dev_info, true); vei->layer.receive = cfvei_receive; vei->layer.transmit = cfvei_transmit; -snprintf (vei->layer.name,CAIF_LAYER_NAME_SZ -1 ,"vei%d" , channel_id); +snprintf (vei->layer.name,CAIF_LAYER_NAME_SZ ,"vei%d" , channel_id);return &vei->layer; }
net/caif/cfvidl.c +1 -1
@@ -29,7 +29,7 @@ struct cflayer *cfvidl_create(u8 channel_id, struct dev_info *dev_info)cfsrvl_init (vid, channel_id, dev_info, false); vid->layer.receive = cfvidl_receive; vid->layer.transmit = cfvidl_transmit; -snprintf (vid->layer.name,CAIF_LAYER_NAME_SZ -1 ,"vid1" ); +snprintf (vid->layer.name,CAIF_LAYER_NAME_SZ ,"vid1" );return &vid->layer; }
Signature · 1 line
2.17.1
From: Weikang shi <[email protected]>
Date: Fri, 17 May 2019 15:59:22 +0800
Quoted 6 lines
From: swkhack <[email protected]>
Because the function snprintf write at most size bytes(including the null byte).So the value of the argument size need not to minus one.
Signed-off-by swkhack <[email protected]>
Applied.