Skip to contentSkip to conversation

dt-bindings: arm: Convert Actions Semi bindings to jsonschema

PATCH In review Rob Herring 3 participants 6 messages May 17, 2019 – Aug 20, 2019

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v3 1/1 dt-bindings: arm: Convert Actions Semi bindings to jsonschema

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml
Documentation/devicetree/bindings/arm/actions.txt deleted +0 -56
deleted file mode 100644
index d54f33c4e0da..000000000000
@@ -1,56 +0,0 @@
-Actions Semi platforms device tree bindings
--------------------------------------------
-
-
-S500 SoC
-========
-
-Required root node properties:
-
- - compatible :  must contain "actions,s500"
-
-
-Modules:
-
-Root node property compatible must contain, depending on module:
-
- - LeMaker Guitar: "lemaker,guitar"
-
-
-Boards:
-
-Root node property compatible must contain, depending on board:
-
- - Allo.com Sparky: "allo,sparky"
- - Cubietech CubieBoard6: "cubietech,cubieboard6"
- - LeMaker Guitar Base Board rev. B: "lemaker,guitar-bb-rev-b", "lemaker,guitar"
-
-
-S700 SoC
-========
-
-Required root node properties:
-
-- compatible :  must contain "actions,s700"
-
-
-Boards:
-
-Root node property compatible must contain, depending on board:
-
- - Cubietech CubieBoard7: "cubietech,cubieboard7"
-
-
-S900 SoC
-========
-
-Required root node properties:
-
-- compatible :  must contain "actions,s900"
-
-
-Boards:
-
-Root node property compatible must contain, depending on board:
-
- - uCRobotics Bubblegum-96: "ucrobotics,bubblegum-96"
Documentation/devicetree/bindings/arm/actions.yaml new file +38 -0
new file mode 100644
index 000000000000..60abd371e474
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/actions.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Actions Semi platforms device tree bindings
+
+maintainers:
+  - Andreas Färber <[email protected]>
+  - Manivannan Sadhasivam <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      # The Actions Semi S500 is a quad-core ARM Cortex-A9 SoC.
+      - items:
+          - enum:
+              - allo,sparky # Allo.com Sparky
+              - cubietech,cubieboard6 # Cubietech CubieBoard6
+          - const: actions,s500
+      - items:
+          - enum:
+              - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
+          - const: lemaker,guitar
+          - const: actions,s500
+
+      # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
+      - items:
+          - enum:
+              - cubietech,cubieboard7 # Cubietech CubieBoard7
+          - const: actions,s700
+
+      # The Actions Semi S900 is a quad-core ARM Cortex-A53 SoC.
+      - items:
+          - enum:
+              - ucrobotics,bubblegum-96 # uCRobotics Bubblegum-96
+          - const: actions,s900
MAINTAINERS +1 -1
index 005902ea1450..be8c3564804c 100644
@@ -1338,7 +1338,7 @@ F:	drivers/pinctrl/actions/*
 F:	drivers/soc/actions/
 F:	include/dt-bindings/power/owl-*
 F:	include/linux/soc/actions/
-F:	Documentation/devicetree/bindings/arm/actions.txt
+F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
 F:	Documentation/devicetree/bindings/dma/owl-dma.txt
 F:	Documentation/devicetree/bindings/i2c/i2c-owl.txt
Signature · 1 line
2.20.1
author maintainer
#1 lore raw
Quoted 12 lines · Rob Herring

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

Quoted 6 lines
 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml

Ping. Please apply or modify this how you'd prefer. I'm not going to keep respinning this.

Rob

#2 lore raw
Quoted 20 lines · Rob Herring
Quoted 12 lines · Rob Herring

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

Quoted 6 lines
 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml
Quoted 3 lines

Ping. Please apply or modify this how you'd prefer. I'm not going to keep respinning this.

Sorry for that Rob.

Andreas, are you going to take this patch? Else I'll pick it up (If you want me to do the PR for next cycle)

Thanks,
Mani

Quoted 1 line

Rob

maintainer
#3 lore raw

Am 14.06.19 um 19:04 schrieb Manivannan Sadhasivam:

Quoted 21 lines · Rob Herring
Quoted 20 lines · Rob Herring
Quoted 18 lines

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml
Quoted 5 lines
Quoted 3 lines

Ping. Please apply or modify this how you'd prefer. I'm not going to keep respinning this.

Sorry for that Rob.

Well, it was simply not clear whether we were supposed to or not. :)

Quoted 2 lines

Andreas, are you going to take this patch? Else I'll pick it up (If you want me to do the PR for next cycle)

I had checked that all previous changes to the .txt file were by myself, so I would prefer if we not license it under GPLv2-only but under the same dual-license (MIT/GPLv2+) as the DTs. That modification would need Rob's approval then.

Regards,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
author maintainer
#4 lore raw
Quoted 23 lines · Andreas Färber

Am 14.06.19 um 19:04 schrieb Manivannan Sadhasivam:

Quoted 21 lines · Rob Herring
Quoted 20 lines · Rob Herring
Quoted 18 lines

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Ping. Please apply or modify this how you'd prefer. I'm not going to keep respinning this.

Sorry for that Rob.

Well, it was simply not clear whether we were supposed to or not. :)

I thought 'To' you and a single patch should be clear enough.

Quoted 7 lines
Quoted 2 lines

Andreas, are you going to take this patch? Else I'll pick it up (If you want me to do the PR for next cycle)

I had checked that all previous changes to the .txt file were by myself, so I would prefer if we not license it under GPLv2-only but under the same dual-license (MIT/GPLv2+) as the DTs. That modification would need Rob's approval then.

That's fine and dual license is preferred. Can you adjust that when applying. Note that the preference for schema is (GPL-2.0 OR BSD-2-Clause), but MIT/GPLv2+ is fine by me.

Rob

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 37 lines · Rob Herring
Quoted 23 lines · Andreas Färber

Am 14.06.19 um 19:04 schrieb Manivannan Sadhasivam:

Quoted 21 lines · Rob Herring
Quoted 20 lines · Rob Herring
Quoted 18 lines

Convert Actions Semi SoC bindings to DT schema format using json-schema.

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Mark Rutland <[email protected]>

---
v3:
- update MAINTAINERS

 .../devicetree/bindings/arm/actions.txt       | 56 -------------------
 .../devicetree/bindings/arm/actions.yaml      | 38 +++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 39 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/actions.txt
 create mode 100644 Documentation/devicetree/bindings/arm/actions.yaml
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Ping. Please apply or modify this how you'd prefer. I'm not going to keep respinning this.

Sorry for that Rob.

Well, it was simply not clear whether we were supposed to or not. :)

I thought 'To' you and a single patch should be clear enough.

Quoted 3 lines
Quoted 2 lines

Andreas, are you going to take this patch? Else I'll pick it up (If you want me to do the PR for next cycle)

Quoted 8 lines
Quoted 4 lines

I had checked that all previous changes to the .txt file were by myself, so I would prefer if we not license it under GPLv2-only but under the same dual-license (MIT/GPLv2+) as the DTs. That modification would need Rob's approval then.

That's fine and dual license is preferred. Can you adjust that when applying. Note that the preference for schema is (GPL-2.0 OR BSD-2-Clause), but MIT/GPLv2+ is fine by me.

Andreas, are you going to take this patch? Else, we can ask Rob to take this through his tree as we don't have any queued patches for v5.4 yet.

Thanks,
Mani

Quoted 2 lines

Rob