Skip to contentSkip to conversation

staging: iio: ad7192: create of_device_id array

PATCH RESEND Superseded Bárbara Fernandes 3 participants 3 messages May 18, 2019 – May 20, 2019

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: iio: ad7192: create of_device_id array

Create list of compatible device ids to be matched with those stated in the device tree.

Co-developed by: Wilson Sales <[email protected]>

---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/staging/iio/adc/ad7192.c +12 -0
index 3d74da9d37e7..cc886f944dbf 100644
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
 	{"ad7195", ID_AD7195},
 	{}
 };
+
+static const struct of_device_id ad7192_of_spi_match[] = {
+	{ .compatible = "adi,ad7190" },
+	{ .compatible = "adi,ad7192" },
+	{ .compatible = "adi,ad7193" },
+	{ .compatible = "adi,ad7195" },
+	{}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
+
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
 static struct spi_driver ad7192_driver = {
 	.driver = {
 		.name	= "ad7192",
+		.of_match_table = ad7192_of_spi_match,
 	},
 	.probe		= ad7192_probe,
 	.remove		= ad7192_remove,
Signature · 1 line
2.22.0.rc0.1.g337bb99195.dirty
maintainer
#1 lore raw
Quoted 6 lines · On Sat, 18 May 2019 19:44:35 -0300 Bárbara Fernandes…

Create list of compatible device ids to be matched with those stated in the device tree.

Co-developed by: Wilson Sales <[email protected]>

Hi Bárbara, Wilson,

One minor issue inline about code ordering.
Actual content is fine.

Thanks,

Jonathan

Quoted 13 lines
---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/staging/iio/adc/ad7192.c +1 -0
index 3d74da9d37e7..cc886f944dbf 100644
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
 	{"ad7195", ID_AD7195},
 	{}
 };
+

drivers/staging/iio/adc/ad7192.c static const struct spi_device_id ad7192_id[] = { · line 823

Quoted 10 lines
drivers/staging/iio/adc/ad7192.c +10 -0
+static const struct of_device_id ad7192_of_spi_match[] = {
+	{ .compatible = "adi,ad7190" },
+	{ .compatible = "adi,ad7192" },
+	{ .compatible = "adi,ad7193" },
+	{ .compatible = "adi,ad7195" },
+	{}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
+

Please keep the declaration of the table alongside the relevant MODULE_DEVICE_TABLE.

In short, better to have your additions after this next line.

Quoted 9 lines
drivers/staging/iio/adc/ad7192.c +1 -0
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
 static struct spi_driver ad7192_driver = {
 	.driver = {
 		.name	= "ad7192",
+		.of_match_table = ad7192_of_spi_match,
 	},
 	.probe		= ad7192_probe,
 	.remove		= ad7192_remove,
#2 lore raw
Quoted 4 lines · Jonathan Cameron

On Sat, 18 May 2019 19:44:35 -0300
Bárbara Fernandes <[email protected]> wrote:

I don't have anything else on top of what Jonathan added.

CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort them out in the next weeks.

Quoted 52 lines
Quoted 6 lines

Create list of compatible device ids to be matched with those stated in the device tree.

Co-developed by: Wilson Sales <[email protected]>

Hi Bárbara, Wilson,

One minor issue inline about code ordering.
Actual content is fine.

Thanks,

Jonathan

Quoted 13 lines
---
 drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/staging/iio/adc/ad7192.c +1 -0
index 3d74da9d37e7..cc886f944dbf 100644
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
      {"ad7195", ID_AD7195},
      {}
 };
+

drivers/staging/iio/adc/ad7192.c static const struct spi_device_id ad7192_id[] = { · line 823

Quoted 10 lines
drivers/staging/iio/adc/ad7192.c +10 -0
+static const struct of_device_id ad7192_of_spi_match[] = {
+     { .compatible = "adi,ad7190" },
+     { .compatible = "adi,ad7192" },
+     { .compatible = "adi,ad7193" },
+     { .compatible = "adi,ad7195" },
+     {}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
+

Please keep the declaration of the table alongside the relevant MODULE_DEVICE_TABLE.

In short, better to have your additions after this next line.

Quoted 9 lines
drivers/staging/iio/adc/ad7192.c +1 -0
 MODULE_DEVICE_TABLE(spi, ad7192_id);
 
 static struct spi_driver ad7192_driver = {
      .driver = {
              .name   = "ad7192",
+             .of_match_table = ad7192_of_spi_match,
      },
      .probe          = ad7192_probe,
      .remove         = ad7192_remove,